syscall: various TestCloneNEWUSERAndRemap/TestEmptyCredGroups test failures

[ALTree]

$ go version
go version devel +b4dd1d9 Sun Jun 25 15:57:18 2017 +0000 linux/amd64

syscall tests in exec_linux_test.go have a fair amount of checks to make sure we skip the tests if we're in no condition to successfully run them, but there must be something missing because I'm seeing the following failures on a GNU/Linux system I use when I run all.bash.

$ cd src/syscall
$ go test 
--- FAIL: TestCloneNEWUSERAndRemapNoRootDisableSetgroups (0.00s)
	exec_linux_test.go:84: Cmd failed with err fork/exec /usr/bin/whoami: invalid argument, output: 
--- FAIL: TestCloneNEWUSERAndRemapNoRootSetgroupsEnableSetgroups (0.00s)
	exec_linux_test.go:124: Unprivileged gid_map rewriting with GidMappingsEnableSetgroups must fail
--- FAIL: TestEmptyCredGroupsDisableSetgroups (0.00s)
	exec_linux_test.go:132: fork/exec /usr/bin/whoami: invalid argument
FAIL
exit status 1
FAIL	syscall	0.021s

This is on a CentOS 7.2 system with kernel 3.10.0-327.36.3.el7.x86_64 from an unprivileged user. The same tests are (correctly) skipped on other GNU/Linux systems I tested, which makes me think something is missing from the "skipping-test" logic.

Not incredibly important but this makes impossible to run all.bash and complete it successfully on this system.

[ianlancetaylor]

Would be nice to get this into 1.9 if we can figure it out.

[ALTree]

I just realized this is a dup of #16283, which was closed as WONTFIX.

[bradfitz]

Okay, you can close it if you'd like.

But can't we detect that user namespaces or whatever aren't available and t.Skip the test instead?

[ALTree]

But can't we detect that user namespaces or whatever aren't available and t.Skip the test instead?

Yes, I think that would be nice.

[Mike-Dunton]

It would be nice to get a patch to skip the tests. Currently blocked on building this in my pipeline

[jessfraz]

I can fix

[jessfraz]

feel free to ping me on these in the future

[gopherbot]

CL https://golang.org/cl/49310 mentions this issue.

[gopherbot]

CL https://golang.org/cl/49311 mentions this issue.

[ALTree]

@jessfraz thanks!