-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/scrypt: update recommended parameters #22082
Comments
cc @agl, @FiloSottile. I tried searching around the various scrypt websites and RFC's and didn't see any updated values for N, though the RFC mentions r=8 and p=1 are still acceptable. |
@agl's scrypt.Key(serialised, nil, 1<<17, 16, 4, 32*3) github.com/codahale/grump defaults to N=20, r=8, p=1. Then again, it also says "You are better off CC'ing a copy of your communications to the FBI than using this." github.com/odeke-em/drive/src/dcrypto/v1 uses N= 262144, r=8, p=1. github.com/dchest/scryptutil uses N=1 << 18, r=8, p=1. |
Pond is extreme here, but things have changed since 2009. Anyone want to ask Colin Percival? |
Sure, I'll send him an email. |
|
Change https://golang.org/cl/67070 mentions this issue: |
Previously we documented recommended parameters for scrypt from 2009, which was eight years ago. Update those parameters and also provide some guidance to users for configuring those settings in 2017. On my late 2015 Macbook Pro, the scrypt benchmark with N=1<<15, r=8, p=1 completes in 91 milliseconds. Add an Example with a salt. Fixes golang/go#22082. Change-Id: I23e3920db67583c9fce093768a32e67ab9c979f5 Reviewed-on: https://go-review.googlesource.com/67070 Reviewed-by: Adam Langley <agl@golang.org>
Previously we documented recommended parameters for scrypt from 2009, which was eight years ago. Update those parameters and also provide some guidance to users for configuring those settings in 2017. On my late 2015 Macbook Pro, the scrypt benchmark with N=1<<15, r=8, p=1 completes in 91 milliseconds. Add an Example with a salt. Fixes golang/go#22082. Change-Id: I23e3920db67583c9fce093768a32e67ab9c979f5 Reviewed-on: https://go-review.googlesource.com/67070 Reviewed-by: Adam Langley <agl@golang.org>
Previously we documented recommended parameters for scrypt from 2009, which was eight years ago. Update those parameters and also provide some guidance to users for configuring those settings in 2017. On my late 2015 Macbook Pro, the scrypt benchmark with N=1<<15, r=8, p=1 completes in 91 milliseconds. Add an Example with a salt. Fixes golang/go#22082. Change-Id: I23e3920db67583c9fce093768a32e67ab9c979f5 Reviewed-on: https://go-review.googlesource.com/67070 Reviewed-by: Adam Langley <agl@golang.org>
Previously we documented recommended parameters for scrypt from 2009, which was eight years ago. Update those parameters and also provide some guidance to users for configuring those settings in 2017. On my late 2015 Macbook Pro, the scrypt benchmark with N=1<<15, r=8, p=1 completes in 91 milliseconds. Add an Example with a salt. Fixes golang/go#22082. Change-Id: I23e3920db67583c9fce093768a32e67ab9c979f5 Reviewed-on: https://go-review.googlesource.com/67070 Reviewed-by: Adam Langley <agl@golang.org>
Previously we documented recommended parameters for scrypt from 2009, which was eight years ago. Update those parameters and also provide some guidance to users for configuring those settings in 2017. On my late 2015 Macbook Pro, the scrypt benchmark with N=1<<15, r=8, p=1 completes in 91 milliseconds. Add an Example with a salt. Fixes golang/go#22082. Change-Id: I23e3920db67583c9fce093768a32e67ab9c979f5 Reviewed-on: https://go-review.googlesource.com/67070 Reviewed-by: Adam Langley <agl@golang.org>
The documentation for the Go scrypt library states:
It is now 2017, so it may be good to update the documented parameters as CPU's have gotten more powerful.
https://godoc.org/golang.org/x/crypto/scrypt
The text was updated successfully, but these errors were encountered: