syscall: TestUnshare failure

[dvn0]

What version of Go are you using (go version)?

I'm using go1.4-bootstrap-20170531 to build 1.8.3

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64" 
GOBIN=""
GOCHAR="6"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/tmp/go"
GOTOOLDIR="/tmp/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?

./all.bash

What did you expect to see?

Build successful

What did you see instead?

ok      net/internal/socktest   0.002s
ok      net/mail        0.005s
ok      net/rpc 0.013s
ok      net/rpc/jsonrpc 0.014s
ok      net/smtp        0.021s
ok      net/textproto   0.003s
ok      net/url 0.005s
ok      os      0.261s
ok      os/exec 0.114s
ok      os/signal       4.243s
ok      os/user 0.002s
ok      path    0.008s
ok      path/filepath   0.006s
ok      reflect 0.101s
ok      regexp  0.097s
ok      regexp/syntax   0.217s
ok      runtime 17.272s
ok      runtime/debug   0.006s
ok      runtime/internal/atomic 0.134s
ok      runtime/internal/sys    0.002s
ok      runtime/pprof   1.236s
ok      runtime/pprof/internal/protopprof       0.018s
ok      runtime/trace   2.405s
ok      sort    0.042s
ok      strconv 0.318s
ok      strings 0.075s
ok      sync    0.137s
ok      sync/atomic     0.031s
--- FAIL: TestUnshare (0.00s)
        exec_linux_test.go:177: Cmd failed with err fork/exec /bin/cat: operation not permitted, output: 
FAIL
FAIL    syscall 0.020s
ok      testing 1.575s
ok      testing/quick   0.050s
ok      text/scanner    0.002s
ok      text/tabwriter  0.003s
ok      text/template   0.204s
ok      text/template/parse     0.030s
ok      time    2.343s
ok      unicode 0.003s
ok      unicode/utf16   0.014s
ok      unicode/utf8    0.005s
ok      vendor/golang_org/x/crypto/chacha20poly1305     0.029s
ok      vendor/golang_org/x/crypto/chacha20poly1305/internal/chacha20   0.002s
ok      vendor/golang_org/x/crypto/curve25519   0.014s
ok      vendor/golang_org/x/crypto/poly1305     0.017s
ok      vendor/golang_org/x/net/http2/hpack     0.005s
ok      vendor/golang_org/x/net/idna    0.004s
ok      vendor/golang_org/x/net/lex/httplex     0.013s
ok      cmd/addr2line   0.506s
ok      cmd/api 0.006s
ok      cmd/asm/internal/asm    0.154s
ok      cmd/asm/internal/lex    0.003s
ok      cmd/compile     3.621s
ok      cmd/compile/internal/gc 6.388s
ok      cmd/compile/internal/ssa        0.244s
ok      cmd/compile/internal/syntax     0.026s
ok      cmd/compile/internal/test       0.002s [no tests to run]
ok      cmd/cover       0.858s
ok      cmd/doc 0.064s
ok      cmd/fix 0.008s
ok      cmd/go  34.673s
ok      cmd/gofmt       0.035s
ok      cmd/internal/goobj      0.002s
ok      cmd/internal/obj        0.002s
ok      cmd/internal/obj/arm64  0.002s
ok      cmd/internal/obj/x86    0.014s
ok      cmd/link        1.782s
ok      cmd/nm  0.373s
ok      cmd/objdump     0.966s
ok      cmd/pack        0.911s
ok      cmd/trace       0.004s
ok      cmd/vendor/golang.org/x/arch/arm/armasm 0.004s
ok      cmd/vendor/golang.org/x/arch/ppc64/ppc64asm     0.003s
ok      cmd/vendor/golang.org/x/arch/x86/x86asm 0.108s
ok      cmd/vet 1.219s
ok      cmd/vet/internal/cfg    0.003s
2017/10/23 09:03:09 Failed: exit status 1

[davecheney]

Ignore it, it’s not important for building a bootstrap compiler.

…

On 23 Oct 2017, at 20:06, dvn ***@***.***> wrote: Please answer these questions before submitting your issue. Thanks! What version of Go are you using (go version)? go1.4-bootstrap-20170531 Does this issue reproduce with the latest release? Yes What operating system and processor architecture are you using (go env)? GOARCH="amd64" GOBIN="" GOCHAR="6" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="" GORACE="" GOROOT="/tmp/go" GOTOOLDIR="/tmp/go/pkg/tool/linux_amd64" CC="gcc" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0" CXX="g++" CGO_ENABLED="1" What did you do? ./all.bash What did you expect to see? Build successful What did you see instead? ok net/internal/socktest 0.002s ok net/mail 0.005s ok net/rpc 0.013s ok net/rpc/jsonrpc 0.014s ok net/smtp 0.021s ok net/textproto 0.003s ok net/url 0.005s ok os 0.261s ok os/exec 0.114s ok os/signal 4.243s ok os/user 0.002s ok path 0.008s ok path/filepath 0.006s ok reflect 0.101s ok regexp 0.097s ok regexp/syntax 0.217s ok runtime 17.272s ok runtime/debug 0.006s ok runtime/internal/atomic 0.134s ok runtime/internal/sys 0.002s ok runtime/pprof 1.236s ok runtime/pprof/internal/protopprof 0.018s ok runtime/trace 2.405s ok sort 0.042s ok strconv 0.318s ok strings 0.075s ok sync 0.137s ok sync/atomic 0.031s --- FAIL: TestUnshare (0.00s) exec_linux_test.go:177: Cmd failed with err fork/exec /bin/cat: operation not permitted, output: FAIL FAIL syscall 0.020s ok testing 1.575s ok testing/quick 0.050s ok text/scanner 0.002s ok text/tabwriter 0.003s ok text/template 0.204s ok text/template/parse 0.030s ok time 2.343s ok unicode 0.003s ok unicode/utf16 0.014s ok unicode/utf8 0.005s ok vendor/golang_org/x/crypto/chacha20poly1305 0.029s ok vendor/golang_org/x/crypto/chacha20poly1305/internal/chacha20 0.002s ok vendor/golang_org/x/crypto/curve25519 0.014s ok vendor/golang_org/x/crypto/poly1305 0.017s ok vendor/golang_org/x/net/http2/hpack 0.005s ok vendor/golang_org/x/net/idna 0.004s ok vendor/golang_org/x/net/lex/httplex 0.013s ok cmd/addr2line 0.506s ok cmd/api 0.006s ok cmd/asm/internal/asm 0.154s ok cmd/asm/internal/lex 0.003s ok cmd/compile 3.621s ok cmd/compile/internal/gc 6.388s ok cmd/compile/internal/ssa 0.244s ok cmd/compile/internal/syntax 0.026s ok cmd/compile/internal/test 0.002s [no tests to run] ok cmd/cover 0.858s ok cmd/doc 0.064s ok cmd/fix 0.008s ok cmd/go 34.673s ok cmd/gofmt 0.035s ok cmd/internal/goobj 0.002s ok cmd/internal/obj 0.002s ok cmd/internal/obj/arm64 0.002s ok cmd/internal/obj/x86 0.014s ok cmd/link 1.782s ok cmd/nm 0.373s ok cmd/objdump 0.966s ok cmd/pack 0.911s ok cmd/trace 0.004s ok cmd/vendor/golang.org/x/arch/arm/armasm 0.004s ok cmd/vendor/golang.org/x/arch/ppc64/ppc64asm 0.003s ok cmd/vendor/golang.org/x/arch/x86/x86asm 0.108s ok cmd/vet 1.219s ok cmd/vet/internal/cfg 0.003s 2017/10/23 09:03:09 Failed: exit status 1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[dvn0]

I was not clear in my initial issue... I'm using the bootstrap compiler to build go1.8.3

[ALTree]

• You don't need go1.4-bootstrap to build the 1.8 compiler on linux/amd64, you can bootstrap with the binaries from https://golang.org/dl/

• If for some reason you really want to bootstrap using go1.4, don't use all.bash, use make.bash, which builds the toolchain without running the old 1.4 tests. This is documented:

After unpacking the Go 1.4 source, cd to the src subdirectory and run make.bash

https://golang.org/doc/install/source

[dvn0]

@ALTree

You don't need go1.4-bootstrap to build the 1.8 compiler on linux/amd64, you can bootstrap with the binaries from https://golang.org/dl/

Trying to understand what you mean here... Are you just suggesting I download the 1.8.x binary instead of trying to build it from source?

If for some reason you really want to bootstrap using go1.4, don't use all.bash, use make.bash, which builds the toolchain without running the old 1.4 tests. This is documented: ...

I have read, and followed that documentation, but that is for building go1.4, which I have already done successfully. I will try running make.bash in the 1.8.3 checkout, and post the results of that, but that's not what the documentation says to do.

[ALTree]

Okay, that wasn't very clear. Now it's clear. No need to mention go1.4-bootstrap: you are seeing test failures when running all.bash in go1.8.3.

[dvn0]

Running make.bash in the 1.8.3 checkout succeeded. Though, I think this is just because it doesn't run the tests.

[ALTree]

Can you try running all.bash with a go1.9.1 source on your system (i.e. doing the same exact thing you did but with go1.9 instead of go1.8)? Does the test still fail?

[dvn0]

Yes, I have tried that, and the test still fails.

[ALTree]

So this is also failing on the current go release. Nice, thanks for the report.

Labelling this as NeedsInvestigation.

[ALTree]

Similar failures we saw in the past: #16283 #20796 were caused by faulty (insufficiently strict) Skip logic.