x/vgo: go-import mod meta tag is not backwards compatible with old go #24751
Labels
Milestone
Comments
|
Since raising this issue (that report a problem with I've therefore updated this issue to use a new dummy package ( |
|
Change https://golang.org/cl/109340 mentions this issue: |
|
Change https://golang.org/cl/114500 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 30, 2018
…cy operation We want authors to be able to publish code that works with both the current standard go command and the planned new go command support for modules. If authors have tagged their code v2 or later, semantic import versioning means the import paths must include a v2 path element after the path prefix naming the module. One option for making this convention compatible with original go get is to move code into a v2 subdirectory of the root. That makes sense for some authors, but many authors would prefer not to move all the code into a v2 subdirectory for a transition and then move it back up once we everyone has a module-aware go command. Instead, this CL teaches the old (non-module-aware) go command a tiny amount about modules and their import paths, to expand the options for authors who want to publish compatible packages. If an author has a v2 of a package, say my/thing/v2/sub/pkg, in the my/thing repo's sub/pkg subdirectory (no v2 in the file system path), then old go get continues to import that package as my/thing/sub/pkg. But when go get is processing code in any module (code in a tree with a go.mod file) and encounters a path like my/thing/v2/sub/pkg, it will check to see if my/thing/go.mod says "module my/thing/v2". If so, the go command will read the import my/thing/v2/sub/pkg as if it said my/thing/sub/pkg, which is the correct "old" import path for the package in question. This CL will be back-ported to Go 1.10 and Go 1.9 as well. Once users have updated to the latest Go point releases containing this new logic, authors will be able to update to using modules within their own repos, including using semantic import paths with vN path elements, and old go get will still be able to consume those repositories. This CL also makes "go get" ignore meta go-import lines using the new "mod" VCS type. This allows a package to specify both a "mod" type and a "git" type, to present more efficient module access to module-aware go but still present a Git repo to the old "go get". Fixes #24751. Fixes #25069. Backport fixes #25139. Change-Id: I378955613a0d63834d4f50f121f4db7e4d87dc0a Reviewed-on: https://go-review.googlesource.com/114500 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
Change https://golang.org/cl/115298 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jun 4, 2018
…y operation We want authors to be able to publish code that works with both the current standard go command and the planned new go command support for modules. If authors have tagged their code v2 or later, semantic import versioning means the import paths must include a v2 path element after the path prefix naming the module. One option for making this convention compatible with original go get is to move code into a v2 subdirectory of the root. That makes sense for some authors, but many authors would prefer not to move all the code into a v2 subdirectory for a transition and then move it back up once we everyone has a module-aware go command. Instead, this CL teaches the old (non-module-aware) go command a tiny amount about modules and their import paths, to expand the options for authors who want to publish compatible packages. If an author has a v2 of a package, say my/thing/v2/sub/pkg, in the my/thing repo's sub/pkg subdirectory (no v2 in the file system path), then old go get continues to import that package as my/thing/sub/pkg. But when go get is processing code in any module (code in a tree with a go.mod file) and encounters a path like my/thing/v2/sub/pkg, it will check to see if my/thing/go.mod says "module my/thing/v2". If so, the go command will read the import my/thing/v2/sub/pkg as if it said my/thing/sub/pkg, which is the correct "old" import path for the package in question. This CL will be back-ported to Go 1.10 and Go 1.9 as well. Once users have updated to the latest Go point releases containing this new logic, authors will be able to update to using modules within their own repos, including using semantic import paths with vN path elements, and old go get will still be able to consume those repositories. This CL also makes "go get" ignore meta go-import lines using the new "mod" VCS type. This allows a package to specify both a "mod" type and a "git" type, to present more efficient module access to module-aware go but still present a Git repo to the old "go get". Fixes #24751. Fixes #25069. This backport to Go 1.9 also had to pick up p.Internal.RawImports from CL 74750 and CL 74356 and use it to prepare an updated set of -importmap arguments for the compiler. (The old code only understood vendor-related rewriting of import paths.) Backport fixes #25140. Change-Id: I378955613a0d63834d4f50f121f4db7e4d87dc0a Reviewed-on: https://go-review.googlesource.com/115298 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
Change https://golang.org/cl/175219 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
May 6, 2019
golang.org/x/tools/go/vcs is significantly behind the upstream cmd/go/internal/get code, and has no support for modules. It continues to implement mechanics for GOPATH mode only. This change is a minimal fix to get it to continue to work in the presence of the module mode-only "mod" VCS type (documented at https://golang.org/cmd/go/#hdr-Remote_import_paths) by effectively implementing IgnoreMod ModuleMode behavior. It is similar to issue golang/go#24751 and a small subset of CL 109340 that fixed it. This helps with module adoption by reducing the harm of adding the "mod" VCS type for vanity import paths, something that was meant to be backwards compatible. While here, also backport CL 14482 (the Token to RawToken change). Fixes golang/go#31845 Updates golang/go#24751 Change-Id: I0852f52cb9bda56879f923337c7f361df8412845 Reviewed-on: https://go-review.googlesource.com/c/tools/+/175219 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?Specifically
vgois as of 5db81b5cd6ab5ee1dd1b1b0ee0843f194ab7b908Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env)?What did you do?
Everything works just fine with
vgo:works fine and gives the output:
But with old
go get:What did you expect to see?
Success.
What did you see instead?
It was my understanding that the
modVCS metago-importshould be able to co-exist with the currentgit(or equivalent) ones in order that a package can bego get-able as well asvgo-compatible. E.g.:But old
go getdoesn't ignore unknown VCS's, and so the two meta tags "clash".Or have I got this wrong?
If I have got this wrong, how can a repo support both?
As a side note, the corresponding test for
matchGoImportlooks a bit suspicious; it doesn't actually assert that the actual error (when there is one) matches the error we want; there are a number of mismatches in the expectations vs the actual result. And there is also no expectation for this scenario of multiple matches.The text was updated successfully, but these errors were encountered: