Skip to content

x/tools: tests are broken after godoc to Flex conversion #27970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradfitz opened this issue Oct 2, 2018 · 2 comments
Closed

x/tools: tests are broken after godoc to Flex conversion #27970

bradfitz opened this issue Oct 2, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 2, 2018

The godoc conversion to Flex CL was submitted without TryBots and broke the x/tools tests:

https://go-review.googlesource.com/c/tools/+/133355

https://build.golang.org/log/d77d425e4f0aa9c1e8a5e1280587d9ed7d29eac0

linux-amd64 at de72c43f78cf31e672cfc93474c9bbb8a1eec925 building tools at 008d18139cb7769f4e539d7aecda5996c7b7217b

../../gopath/src/golang.org/x/tools/godoc/dl/dl.go:29:2: cannot find package "cloud.google.com/go/datastore" in any of:
	/workdir/go/src/cloud.google.com/go/datastore (from $GOROOT)
	/workdir/gopath/src/cloud.google.com/go/datastore (from $GOPATH)
../../gopath/src/golang.org/x/tools/internal/memcache/memcache.go:18:2: cannot find package "github.com/gomodule/redigo/redis" in any of:
	/workdir/go/src/github.com/gomodule/redigo/redis (from $GOROOT)
	/workdir/gopath/src/github.com/gomodule/redigo/redis (from $GOPATH)
../../gopath/src/golang.org/x/tools/godoc/short/short.go:25:2: cannot find package "google.golang.org/appengine/user" in any of:
	/workdir/go/src/google.golang.org/appengine/user (from $GOROOT)
	/workdir/gopath/src/google.golang.org/appengine/user (from $GOPATH)
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Oct 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Oct 2, 2018
@bradfitz bradfitz changed the title x/tools: tests are broken x/tools: tests are broken after godoc to Flex conversion Oct 2, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/139197 mentions this issue: godoc: move third-party godoc deps behind build tag

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/150600 mentions this issue: [release-branch.go1.11] godoc: move third-party godoc deps behind build tag

gopherbot pushed a commit to golang/tools that referenced this issue Nov 21, 2018
@bradfitz @dmitshur
[release-branch.go1.11] godoc: move third-party godoc deps behind bui…
ddbd6be 
…ld tag

Updates golang/go#28893
Updates golang/go#27970

Change-Id: I6de10c260f31721bf83073ef5b140442c3ef7eb0
Reviewed-on: https://go-review.googlesource.com/c/139197
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/150600
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 20, 2019
@rsc rsc unassigned broady Jun 23, 2022
henderjon pushed a commit to oggodoc/godoc that referenced this issue Jun 13, 2024
@bradfitz
godoc: move third-party godoc deps behind build tag
a8e5fd7 
Fixes golang/go#27970

Change-Id: I6de10c260f31721bf83073ef5b140442c3ef7eb0
Reviewed-on: https://go-review.googlesource.com/c/139197
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @broady @gopherbot