-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: TestLookupDotsWithRemoteSource is flaky #27992
Comments
Any chance there was a recent change to whether the builders set |
Once http://golang.org/cl/102875 lands, I will smash the use of external DNS speakers such as rsc.io or some public full resolver then flaky tests disappear. For now, I have no spare time to debug the circumstances running the tests, also not sure there's a way to sneak in the (protected) circumstances. |
@mikioh should we just disable this test until 1.13? |
Yes, please. Will try to allocate my spare time for Go 1.13 devel cycle. |
Change https://golang.org/cl/151799 mentions this issue: |
Updates #27992 Change-Id: Ic327df7cc5002a3d537f9117559c25f30e1eab9c Reviewed-on: https://go-review.googlesource.com/c/151799 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mikioh done. Assigning back to you. Thanks. |
Here's the same failure mode on
|
|
I did some digging, and I believe that this flakiness is caused by the hard-coded timeout and attempt limits in Lines 41 to 45 in 825ff1e
On my Linux workstation, I would recommend:
|
Another flake by standard try-bot https://storage.googleapis.com/go-build-log/43f55574/windows-386-2008_d562679e.log while testing https://go-review.googlesource.com/c/go/+/416975 Alex |
Another flake: |
Found new dashboard test flakes for:
2022-08-02 18:51 windows-386-2008 go@e9d7f54a net.TestLookupDotsWithRemoteSource (log)
2022-08-11 20:03 windows-386-2012 go@72a857a2 net.TestLookupDotsWithRemoteSource (log)
2022-08-16 17:18 windows-amd64-2008 go@805305e2 net.TestLookupDotsWithRemoteSource (log)
2022-08-18 16:16 windows-amd64-2008 go@b6149224 net.TestLookupDotsWithRemoteSource (log)
2022-08-22 18:51 windows-amd64-2016 go@a726c9f6 net.TestLookupDotsWithRemoteSource (log)
2022-08-23 22:44 windows-amd64-2008 go@ab8a2c5e net.TestLookupDotsWithRemoteSource (log)
2022-08-31 20:05 windows-386-2008 go@9085ff58 net.TestLookupDotsWithRemoteSource (log)
2022-08-31 22:22 windows-amd64-race go@e4b624ea net.TestLookupDotsWithRemoteSource (log)
2022-09-02 02:09 windows-amd64-longtest go@a31c062c net.TestLookupDotsWithRemoteSource (log)
2022-09-08 14:57 windows-amd64-race go@530a2369 net.TestLookupDotsWithRemoteSource (log)
2022-09-08 21:18 windows-amd64-longtest go@e20106ac net.TestLookupDotsWithRemoteSource (log)
2022-09-21 01:56 windows-amd64-longtest go@d11c58ee net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2022-09-29 14:51 windows-amd64-race go@9861e8b2 net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2022-11-04 15:03 windows-386-2012 go@edfe0783 net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2022-11-09 17:33 freebsd-arm64-dmgk go@7a92c4fc net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2022-11-08 14:52 freebsd-arm64-dmgk go@a1c31d68 net.TestLookupDotsWithRemoteSource (log)
2022-11-09 17:39 aix-ppc64 go@cd8d1bca net.TestLookupDotsWithRemoteSource (log)
2022-11-09 17:39 freebsd-arm64-dmgk go@cd8d1bca net.TestLookupDotsWithRemoteSource (log)
2022-11-09 18:44 freebsd-arm64-dmgk go@9e0b6c11 net.TestLookupDotsWithRemoteSource (log)
2022-11-10 18:18 aix-ppc64 go@fd0c0db4 net.TestLookupDotsWithRemoteSource (log)
2022-11-10 18:18 freebsd-arm64-dmgk go@fd0c0db4 net.TestLookupDotsWithRemoteSource (log)
2022-11-10 18:29 aix-ppc64 go@d931b3b7 net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2023-01-17 19:56 windows-amd64-race go@354c8fb4 net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2023-04-12 20:54 linux-amd64-longtest-race go@f58c6ccc net.TestLookupDotsWithRemoteSource (log)
|
Found new dashboard test flakes for:
2023-05-10 22:43 freebsd-amd64-12_3 go@639957eb net.TestLookupDotsWithRemoteSource (log)
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This test is failing again, now the
|
#64937 (comment) notes that this seems to be fixed, though we're still seeing some failures (probably from cached responses?). |
I wouldn't say that this is “fixed” so much as “back in remission”. Ideally the test should be made hermetic, but adding a hermetic DNS server to the Go repo for testing purposes seems like kind of a tough sell too. 😅 |
It is an important ticket... |
Found new dashboard test flakes for:
2023-12-30 00:23 gotip-linux-386-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-linux-amd64-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-linux-amd64-longtest-race go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-openbsd-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-solaris-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-386 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64-race go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-linux-386-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-linux-amd64-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-linux-amd64-longtest-race go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-openbsd-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-solaris-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-386 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64-race go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
|
We are getting flaky test failures in net. This has been somewhat rare in the past few months, but it has failed the last 5 builds, so probably worth looking into now.
Looks very related to #16865 closed 2 years ago.
The text was updated successfully, but these errors were encountered: