Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: Build failure inSWIG tests after commit 700575be81 #28834

Closed
siebenmann opened this issue Nov 16, 2018 · 1 comment
Closed

cmd/go: Build failure inSWIG tests after commit 700575be81 #28834

siebenmann opened this issue Nov 16, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.12

Comments

@siebenmann
Copy link

What version of Go are you using (go version)?

$ go version
go version devel +700575be81 Thu Nov 15 21:51:50 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?

This reproduces from commit 700575b onward (and doesn't seem to be being picked up by the builders, perhaps because none of them have SWIG installed).

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOOS="linux"

What did you do?

Since commit 700575b, building Go git tip from source fails with an error in the SWIG tests:

##### ../misc/swig/callback
# _/data/code/go-lang/go/misc/swig/callback
vet: $WORK/b050/_cgo_gotypes.go:7:8: could not import unsafe (can't resolve import "")
FAIL    _/data/code/go-lang/go/misc/swig/callback [build failed]
2018/11/16 11:31:28 Failed: exit status 2

I also have gcc-go installed on this system, in case it makes a difference in SWIG's behavior. This is a Fedora 28 system with swig-3.0.12-17.fc28.x86_64, but I see the same build failure on Ubuntu 18.04 with their version of SWIG. As expected, Go builds on an Ubuntu 18.04 machine that doesn't have SWIG installed.
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Nov 16, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Nov 16, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/149964 mentions this issue: cmd/go: packages that use SWIG depend on "unsafe"

@josharian josharian mentioned this issue Nov 18, 2018
Closed
bradfitz pushed a commit that referenced this issue Nov 21, 2018
@ianlancetaylor @josharian
cmd/go: packages that use SWIG depend on "unsafe"
404ab86 
Fixes #28834

Change-Id: I95d6874e62d36974415f43843881a4ae85b3c7ce
Reviewed-on: https://go-review.googlesource.com/c/149964
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
@golang golang locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@siebenmann @ianlancetaylor @gopherbot