Skip to content

website: ability to add shortlinks #29988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
dmitshur opened this issue Jan 30, 2019 · 3 comments
Closed
1 task

website: ability to add shortlinks #29988

dmitshur opened this issue Jan 30, 2019 · 3 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@dmitshur
Copy link
Member

https://golang.org/s currently says:

Link creation temporarily unavailable. See golang.org/issue/27205.

golang.org/issue/27205 is closed now, but it had the following follow-up task that wasn't yet complete:

  • ability to add shortlinks (old app had a login, GAE Flex doesn't have authed handlers)

This issue is now tracking that task.
@dmitshur dmitshur added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Jan 30, 2019
@dmitshur dmitshur added this to the Unreleased milestone Jan 30, 2019
@dmitshur dmitshur mentioned this issue Jan 30, 2019
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/160377 mentions this issue: godoc/short: point to new tracking issue for shortlink creation

gopherbot pushed a commit to golang/tools that referenced this issue Jan 30, 2019
@dmitshur
godoc/short: point to new tracking issue for shortlink creation
1c35819 
There's a new dedicated issue tracking this task, point to it instead
of the previous large issue which has been closed by now.

Updates golang/go#29988
Updates golang/go#27205

Change-Id: Ib1443d14a6369322b36cdf8305344a35c421a2e5
Reviewed-on: https://go-review.googlesource.com/c/160377
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/160477 mentions this issue: [release-branch.go1.11] godoc/short: point to new tracking issue for shortlink creation

gopherbot pushed a commit to golang/tools that referenced this issue Feb 6, 2019
@dmitshur
[release-branch.go1.11] godoc/short: point to new tracking issue for …
0114a60 
…shortlink creation

There's a new dedicated issue tracking this task, point to it instead
of the previous large issue which has been closed by now.

Updates golang/go#29988
Updates golang/go#27205

Change-Id: Ib1443d14a6369322b36cdf8305344a35c421a2e5
Reviewed-on: https://go-review.googlesource.com/c/160377
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1c35819)
Reviewed-on: https://go-review.googlesource.com/c/160477
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 1, 2019
rsc added a commit to rsc/tmp that referenced this issue Jul 20, 2019
@rsc
goshort: command to update golang.org/s links
720008f 
Works around golang/go#29988.
@griesemer griesemer modified the milestones: Unreleased, Backlog Nov 3, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/238545 mentions this issue: all: add cmd/admingolangorg

@golang golang locked and limited conversation to collaborators Jun 18, 2021
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
cmd/admingolangorg: add command serving an admin interface
95da75c 
This change re-enables the /s/ link shortener admin interface,
running as its own App Engine service on the go111 runtime,
which still supports the “login: admin” option in app.yaml.

+ The golangorg build constraint on the internal/memcache and
  internal/short packages is removed to allow easy import
+ A new function, AdminHandler is introduced in the short package
  to allow for registering the handler outside of it
+ Some page cleanup to leverage modern HTML and JS capabilities,
  obviating the need for jQuery, which has been removed
+ Clients for Redis and Cloud Datastore have been updated to
  the latest versions

Fixes golang/go#29988

Change-Id: If6ca75e85e16a7d86bb5dafcf08b27d2dc36f530
Reviewed-on: https://go-review.googlesource.com/c/website/+/238545
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @griesemer @gopherbot