Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.12 binaries rejected from mac app store due to ___getdirentries64 [1.12 backport] #31244

Closed
gopherbot opened this issue Apr 3, 2019 · 3 comments
Closed

go 1.12 binaries rejected from mac app store due to ___getdirentries64 [1.12 backport] #31244

gopherbot opened this issue Apr 3, 2019 · 3 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.2

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #30933 to be considered for backport to the next 1.12 minor release.

@gopherbot please consider this for backport to 1.12.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 3, 2019
@gopherbot gopherbot mentioned this issue Apr 3, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.2 milestone Apr 3, 2019
@randall77
Copy link
Contributor

This issue prevents binaries built with 1.12 from being uploaded to the macOS App store.
1.11 binaries used to work.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/170640 mentions this issue: [release-branch.go1.12] syscall: avoid _getdirentries64 on darwin

@gopherbot
Copy link
Contributor Author

Closed by merging 731ebf4 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Apr 5, 2019
@randall77 @andybons
[release-branch.go1.12] syscall: avoid _getdirentries64 on darwin
731ebf4 
Getdirentries is implemented with the __getdirentries64 function
in libSystem.dylib. That function works, but it's on Apple's
can't-be-used-in-an-app-store-application list.

Implement Getdirentries using the underlying fdopendir/readdir_r/closedir.
The simulation isn't faithful, and could be slow, but it should handle
common cases.

Don't use Getdirentries in the stdlib, use fdopendir/readdir_r/closedir
instead (via (*os.File).readdirnames).

(Incorporates CL 170837 and CL 170698, which were small fixes to the
original tip CL.)

Fixes #31244

Update #28984

RELNOTE=yes

Change-Id: Ia6b5d003e5bfe43ba54b1e1d9cfa792cc6511717
Reviewed-on: https://go-review.googlesource.com/c/go/+/168479
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 9da6530)
Reviewed-on: https://go-review.googlesource.com/c/go/+/170640
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@halseth halseth mentioned this issue May 2, 2019
Closed
@golang golang locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.2
Development

No branches or pull requests
2 participants
@randall77 @gopherbot