Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: accept -Wl,-R,path [1.12 backport] #32168

Closed
gopherbot opened this issue May 21, 2019 · 2 comments
Closed

cmd/go: accept -Wl,-R,path [1.12 backport] #32168

gopherbot opened this issue May 21, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.6

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #32167 to be considered for backport to the next 1.12 minor release.

Yes, we should accept that. We currently accept -Wl,-rpath but not -Wl,-R.

If anybody wants to send a patch, the place is cmd/go/internal/work/security.go.

@gopherbot Please open backport to 1.12.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 21, 2019
@gopherbot gopherbot mentioned this issue May 21, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.6 milestone May 21, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/181437 mentions this issue: [release-branch.go1.12] cmd/go: accept -Wl,-R/path/

@gopherbot
Copy link
Contributor Author

Closed by merging 3887549 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Jun 10, 2019
@zx2c4 @ianlancetaylor
[release-branch.go1.12] cmd/go: accept -Wl,-R/path/
3887549 
This is a backport of CL 178397.

Updates #32167
Fixes #32168

Change-Id: Idb16a01d56814ea09ad277798787355dc6a3121f
Reviewed-on: https://go-review.googlesource.com/c/go/+/181437
Reviewed-by: Jason Donenfeld <Jason@zx2c4.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Jason Donenfeld <Jason@zx2c4.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 10, 2019
@golang golang locked and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.6
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot