Skip to content

doc: summarize net/http noteworthy improvements for Go1.13 #33396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odeke-em opened this issue Aug 1, 2019 · 3 comments
Closed

doc: summarize net/http noteworthy improvements for Go1.13 #33396

odeke-em opened this issue Aug 1, 2019 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone

Comments

@odeke-em
Copy link
Member

odeke-em commented Aug 1, 2019

This issue is a placeholder for us to comb through the net/http improvements such as #30377 (comment) from @vancluever in which we now use SendFile/ReadFrom for Transport.Body if possible

@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Aug 1, 2019
@odeke-em odeke-em self-assigned this Aug 1, 2019
@odeke-em odeke-em added this to the Go1.13 milestone Aug 1, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/188457 mentions this issue: doc/go1.13: document net/http.Transport.Request.Body unfurling

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/188477 mentions this issue: doc/go1.13: add more release notes for net/http

@vancluever
Copy link
Contributor

Thanks again @odeke-em!

gopherbot pushed a commit that referenced this issue Aug 2, 2019
Documents the work from:
* CL 163599
* CL 163737

which now uses the Request.Body's io.ReaderFrom implementation,
if available, and permits system level optimizations such as
"sendfile" to be used to transmit/upload the Body, which greatly
speeds up file uploads.

Updates #33396

Change-Id: I7b8315c4b3e57ad47bb9be2b0c838857875d4bd5
Reviewed-on: https://go-review.googlesource.com/c/go/+/188457
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants