syscall: fd passing fails on OpenBSD

[bradfitz]

This test fails on OpenBSD:

http://code.google.com/p/go/source/detail?r=160ec5506cb7740be6702e5996fa05059578c4a5

The test is now removed from the tree, so:

$ hg update -C 160ec5506cb
and then edit src/pkg/syscall/passfd_test.go to change "probablyopenbsd" to
"openbsd", then watch it fail, unable to find the inherited UnixConn in the
child process.

[rsc]

Comment 1:

Status changed to Accepted.

[rsc]

Comment 2:

Labels changed: added go1.1.

[rsc]

Comment 3:

Labels changed: added size-m.

[rsc]

Comment 4:

Labels changed: added suggested.

[gopherbot]

Comment 5 by guelfey:

After looking into this issue, I found out that it is apparently due to the getsockname
implementation on OpenBSD. While the manpage states that obtaining the address is not
supported for Unix sockets, the address family doesn't seem to be set either if the
socket is not bound (see the attached example). This means that net.FileConn doesn't
recognize it as a Unix socket.

Attachments:

1. getsockname_test.c (552 bytes)

[alberts]

Comment 6:

any chance OpenBSD has SO_DOMAIN support for getsockopt?

[gopherbot]

Comment 7 by guelfey:

nope

[mdempsky]

Comment 8:

@guelfey: That bug was fixed last October
(http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c#rev1.69), and will be
included in the upcoming 5.3 release.  If I run your test program on a recent snapshot
release, the output is "got 1 expected 1".

[davecheney]

Comment 9:

This issue was closed by revision f853e9a.

Status changed to Fixed.