-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Closed
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.
Milestone
Description
What version of Go are you using (go version)?
$ go version Latest gollvm on arm/x86
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
What did you do?
Sync llvm, gollvm and gofrontend to latest version and build.
What did you expect to see?
Build pass.
What did you see instead?
A few build errors like the following one.
/home/xiaji01/src/gollvm/tools/gollvm/driver/GollvmOptions.cpp:43:23: error: ‘make_unique’ is not a member of ‘llvm’; did you mean ‘std::make_unique’?
43 | auto Result = llvm::make_unique();
They are caused by the recent llvm changes:
commit 114087caa6f95b526861c3af94b3093d9444c57b
[llvm] Migrate llvm::make_unique to std::make_unique
commit 1bfa43df5886a8c51442dd457b3a89c59ce02b46
Recommit r368812 "[llvm/Object] - Convert SectionRef::getName() to return Expected<>"
commit 0d8949846a525ca1920771aeea88d1dcaa1779f7
[llvm/Object] - Convert SectionRef::getName() to return Expected<>
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.