Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: apps built with go 1.13, still rejected by Apple app store [1.13 backport] #34170

Closed
gopherbot opened this issue Sep 7, 2019 · 2 comments
Closed

x/mobile: apps built with go 1.13, still rejected by Apple app store [1.13 backport] #34170

gopherbot opened this issue Sep 7, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge mobile Android, iOS, and x/mobile
Milestone
Go1.13.3

Comments

@gopherbot
Copy link
Contributor

@eliasnaur requested issue #34133 to be considered for backport to the next 1.13 minor release.

@gopherbot please consider this for backport to 1.13 to allow Go apps through the App Store checks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 7, 2019
@gopherbot gopherbot mentioned this issue Sep 7, 2019
Closed
@gopherbot gopherbot added this to the Unreleased milestone Sep 7, 2019
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Sep 7, 2019
@gopherbot gopherbot modified the milestones: Unreleased, Go1.13.1 Sep 7, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/193847 mentions this issue: [release-branch.go1.13] syscall: disable sysctl on iOS

@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 25, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 25, 2019
@gopherbot
Copy link
Contributor Author

Closed by merging a462e9f to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 25, 2019
@eliasnaur
[release-branch.go1.13] syscall: disable sysctl on iOS
a462e9f 
Sysctl is blocked by the App Store submission checks.

This is a squash of the following cherry-picked CLs:

https://golang.org/cl/193843
https://golang.org/cl/193844
https://golang.org/cl/193845
https://golang.org/cl/193846

Fixes #34170

Change-Id: I9e83cf87e942d6249e9bb67a95dba230e44badd9
Reviewed-on: https://go-review.googlesource.com/c/go/+/193843
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/193847
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge mobile Android, iOS, and x/mobile
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @katiehockman