x/build/devapp: handle module dependencies more intelligently in Dockerfile #34192
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
toothrot
added
Builders
|
What kind of speedup do we get from this optimization? |
|
/cc @bradfitz Might be most familiar with the effect of this optimization. |
|
The point is to speed up incremental development. Checking now, it looks like it's ~11 seconds to do an increment "make docker-prod" after doing a minor change to x/build/devapp/*.go. But without it, incremental builds are ~22 seconds, assuming you're on a really fast network (Google corp, wired). Because without those lines you pull lots of source from proxy.golang.org. |
|
Change https://golang.org/cl/197302 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Sep 26, 2019
Set the working directory in the Dockerfile to be inside the golang.org/x/build module before running go install on cmd/tip. Otherwise, it just installs the latest cmd/tip from the internet rather than the intended local version. (All other Dockerfiles in x/build had this line, except cmd/tip.) Remove duplicate and unneeded WORKDIR instruction from two other Dockerfiles to improve consistency. Fix a rare race condition setting p.err when os.MkdirAll fails. Add a log message when a new server has been started successfully and the side switches. This will make logs easier to read. Fixes golang/go#34526 Updates golang/go#34192 Change-Id: Iab8124f5c872fb87844e8e2f9b31637ce395f11b Reviewed-on: https://go-review.googlesource.com/c/build/+/197302 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com>
codebien
pushed a commit
to codebien/build
that referenced
this issue
Nov 13, 2019
Set the working directory in the Dockerfile to be inside the golang.org/x/build module before running go install on cmd/tip. Otherwise, it just installs the latest cmd/tip from the internet rather than the intended local version. (All other Dockerfiles in x/build had this line, except cmd/tip.) Remove duplicate and unneeded WORKDIR instruction from two other Dockerfiles to improve consistency. Fix a rare race condition setting p.err when os.MkdirAll fails. Add a log message when a new server has been started successfully and the side switches. This will make logs easier to read. Fixes golang/go#34526 Updates golang/go#34192 Change-Id: Iab8124f5c872fb87844e8e2f9b31637ce395f11b Reviewed-on: https://go-review.googlesource.com/c/build/+/197302 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The x/build/devapp Dockerfile contains extra steps to optimize the speed of repeated docker builds when the
go.modorgo.sumfiles have not changed. It would be nice to have a more automated way of doing this that doesn't require us to remember to add some our dependencies manually inside of our Dockerfile.See golang.org/cl/193878.
The text was updated successfully, but these errors were encountered: