encoding/xml: createAttrPrefix should ban "XMLanything" case insensitive, not just "xmlanything"

[tgulacsi]

What version of Go are you using (go version)?

$ go version
go version go1.13.3 linux/amd64

Does this issue reproduce with the latest release?

AFAIK yes.

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/gthomas/bin"
GOCACHE="/home/gthomas/.cache/go-build"
GOENV="/home/gthomas/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY="unosoft.hu"
GONOSUMDB="unosoft.hu"
GOOS="linux"
GOPATH="/home/gthomas/go"
GOPRIVATE="unosoft.hu"
GOPROXY="http://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build491111576=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/u1HWd2zff8x

What did you expect to see?

<element xmlns:_XMLSchema-instance="http://www.w3.org/2001/XMLSchema-instance" _XMLSchema-instance:nil="true"></element>

What did you see instead?

<element xmlns:XMLSchema-instance="http://www.w3.org/2001/XMLSchema-instance" XMLSchema-instance:nil="true"></element>

[tgulacsi]

https://www.w3.org/TR/xml-names/ says

All other prefixes beginning with the three-letter sequence x, m, l, in any case combination, are reserved.

under 3 "Declaring Namespaces".

Also https://www.w3.org/TR/REC-xml/ says

Names beginning with the string "xml", or with any string which would match (('X'|'x') ('M'|'m') ('L'|'l')), are reserved for standardization in this or future versions of this specification.

under "2.3 Common Syntactic Constructs".

[gopherbot]

Change https://golang.org/cl/203417 mentions this issue: encoding/xml: namespace prefix case insensitive check

[tgulacsi]

Can I help with anything?
The second version of my CL is simpler and more explicit, I hope.

[tgulacsi]

Ping.

[odeke-em]

Thank you for filing this bug and for mailing the CL! I shall provide some feedback on your change, and awesome to have your contribution to the Go project!

[odeke-em]

@tgulacsi I sent some feedback to your CL about 20 days ago, please take a look, so that we can get it going before the code freeze. Thank you.

[tgulacsi]

Sorry, haven't seen it.

[gopherbot]

Change https://golang.org/cl/240012 mentions this issue: doc/go1.15: remove encoding/xml doc

[gopherbot]

Change https://golang.org/cl/240179 mentions this issue: Revert "encoding/xml: fix reserved namespace check to be case-insensitive"

[odeke-em]

Reopening and retargeting for Go1.16 to address the raised cause of rollback during Go1.15.

[tgulacsi]

Ping

[tgulacsi]

Ping

[ianlancetaylor]

@tgulacsi A minor point, but if you want us to review a change, please ping the change, not the associated issue. Thanks.

[ianlancetaylor]

But now I'm not sure what is going on here. Is there a change to review? What is the ping for? Who are you pinging?

[tgulacsi]

I'd like some directions - my previous CL was reviewed, accepted, then reverted.

Now I don't know what was the problem with it, what should I change to have it accepted - without information, I can only reissue the same CL.

[gopherbot]

Change https://golang.org/cl/254978 mentions this issue: encoding/xml: opt-in fix reserved namespace check to be case-insensitive

[tgulacsi]

PTAL https://go-review.googlesource.com/c/go/+/254978 - it reintroduces the same code change, but puts it behind an Encoder option.

[ianlancetaylor]

@tgulacsi Thanks for the context. I look at dozens of different issues every day, so I can't always keep them all in my head.

The CL that reverted your CL, https://golang.org/cl/240179, says "Reason for revert: This change changes uses of tags like "XMLSchema-instance" without any recourse" and refers to #39876. #39876 explains the problem, and you commented there. That issue has a test case whose behavior changed. Any change we make should not change the behavior of that test case, or other similar test cases.

The Go project takes backward compatibility very seriously. We do not want to break existing programs. There needs to be a very good reason to not do that. Perhaps we made a mistake in the fix for #5040, but we still don't want to break existing programs.

Worse, as #39876 says, after your earlier change (https://golang.org/cl/203417) there was no way for a program to get the string that it got before. So not only did the behavior change, there was no way to get the old behavior.

In your new CL (https://golang.org/cl/254978) you are introducing new API: a new method xml.(*Encoder).XMLPrefixCaseInsensitive. We usually use the proposal process for new API.

But first let's take a step back.

What is the real problem here that we are trying to solve? What goes wrong if we don't fix this? Perhaps you understand that, but I don't. Perhaps that can help guide us to the right solution.

Thanks.

[tgulacsi]

From one of my clients, I got back this:

<bmRating xmlns:XMLSchema-instance="http://www.w3.org/2001/XMLSchema-instance" XMLSchema-instance:nil="true"></bmRating>

error: Prefix can't begin with XML: XMLSchema-instance

Prefixes beginning with "xml" (regardless of casing) are reserved for use by XML.

And https://www.w3.org/TR/REC-xml/ says she's right.

That's what I try to solve.

[ianlancetaylor]

Sorry if this is a dumb question, but where is the string XMLSchema-instance coming from?

[tgulacsi]

As far as I see, it's https://github.com/golang/go/blob/master/src/encoding/xml/marshal.go#L339 where it starts to pick a short name (tag?) for the namespace. If possible, it uses the namespace url's path's last section.

AFAIK a random name would work, too - that's why I don't understand what does it break.
That short name could be anything - though it cannot start with [xX][mM][lL].

[ianlancetaylor]

@tgulacsi OK, I've looked into this, and I've come around to the view that you are correct: we should make this change and fix code that breaks.

[ianlancetaylor]

Thanks for your patience with this.

[gopherbot]

Change https://golang.org/cl/264024 mentions this issue: encoding/xml: fix reserved namespace check to be case-insensitive

[tgulacsi]

Thank you @ianlancetaylor and @odeke-em !
This is not a big issue for me, I have and use a not-so-simple-but-working workaround.

The big thing is that I thought I can contribute to the Go project, and have a tiny improvement on Go,
my beloved language, standard library and ecosystem.
I was in joy and then it's been rolled back.

So thanks again for looking again into it, and rolling forward!