Skip to content

PowerRegisterSuspendResumeNotification error on Azure App Services with go 1.13.7 [1.13 backport] #37230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 14, 2020 · 3 comments
Closed

PowerRegisterSuspendResumeNotification error on Azure App Services with go 1.13.7 [1.13 backport] #37230

gopherbot opened this issue Feb 14, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.10

Comments

@gopherbot
Copy link
Contributor

@networkimprov requested issue #37149 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport. It's another instance of this regression...
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 14, 2020
@gopherbot gopherbot mentioned this issue Feb 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Feb 14, 2020
@cagedmantis cagedmantis modified the milestones: Go1.13.9, Go1.13.10 Mar 19, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/224585 mentions this issue: [release-branch.go1.13] runtime: ignore error returned by PowerRegisterSuspendResumeNotification

@ianlancetaylor
Copy link
Contributor

Any Go program fails to start in certain restricted environments when running Windows. Cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 25, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging d6224d3 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 25, 2020
@alexbrainman @ianlancetaylor
[release-branch.go1.13] runtime: ignore error returned by PowerRegist…
d6224d3 
…erSuspendResumeNotification

It appears that PowerRegisterSuspendResumeNotification is not supported
when running inside Docker - see issues #35447, #36557 and #37149.

Our current code relies on error number to determine Docker environment.
But we already saw PowerRegisterSuspendResumeNotification return
ERROR_FILE_NOT_FOUND, ERROR_INVALID_PARAMETERS and ERROR_ACCESS_DENIED
(see issues above). So this approach is not sustainable.

Just ignore PowerRegisterSuspendResumeNotification returned error.

For #37149
Fixes #37230

Change-Id: I2beba9d45cdb8c1efac5e974e747827a6261915a
Reviewed-on: https://go-review.googlesource.com/c/go/+/219657
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
(cherry picked from commit d467f3b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/224585
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@AlexEyler AlexEyler mentioned this issue Jun 9, 2020
Closed
This was referenced Jun 22, 2020
Merged
Closed
Merged
@golang golang locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.10
Development

No branches or pull requests
3 participants
@cagedmantis @ianlancetaylor @gopherbot