Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: creates many /tmp/go-build* directories #37368

Closed
stamblerre opened this issue Feb 21, 2020 · 3 comments
Closed

x/tools/gopls: creates many /tmp/go-build* directories #37368

stamblerre opened this issue Feb 21, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

See microsoft/vscode-go#3061.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Feb 21, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 21, 2020
@stamblerre stamblerre mentioned this issue Feb 21, 2020
Closed
@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 21, 2020
@OneOfOne
Copy link
Contributor

Possibly related #21135.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220737 mentions this issue: all: consolidate invokeGo implementations

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220738 mentions this issue: internal/gocommand: kill gracefully

gopherbot pushed a commit to golang/tools that referenced this issue Feb 25, 2020
@heschi
all: consolidate invokeGo implementations
c5cec67 
Over time we have accumulated a disturbing number of ways to run the Go
command, each of which supported slightly different features and
workarounds. Combine all of them.

This unavoidably introduces some changes in debug logging behavior; I
think we should try to fix them incrementally and consistently.

Updates golang/go#37368.

Change-Id: I664ca8685bf247a226be3cb807789c2fcddf233d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220737
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah mentioned this issue Mar 30, 2020
Closed
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@OneOfOne OneOfOne mentioned this issue Sep 11, 2020
Open
@golang golang locked and limited conversation to collaborators Jul 22, 2021
apstndb pushed a commit to apstndb/gotoolsdiff that referenced this issue Jan 11, 2025
@heschi
internal/gocommand: kill gracefully
3216e59 
We want the go command to get a chance to do its cleanups. Send it
Interrupt before Kill.

Fixes golang/go#37368.

Change-Id: Id891d2f4f85aae30d2aaa19b9c854d2346ec6e1f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220738
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@OneOfOne @stamblerre @gopherbot