all: remove darwin/386 #37610

andybons · 2020-03-02T21:38:54Z

Per #34749, we’re going to remove darwin/386 for Go 1.15. This is a tracking issue for that work.

Some affected files (taken from above issue. Thanks, @bradfitz):

./runtime/rt0_darwin_386.s
./runtime/cgo/gcc_darwin_386.c
./runtime/signal_darwin_386.go
./runtime/defs_darwin_386.go
./runtime/sys_darwin_386.s
./debug/macho/testdata/gcc-386-darwin-exec
./debug/macho/testdata/fat-gcc-386-amd64-darwin-exec
./debug/macho/testdata/clang-386-darwin.obj
./debug/macho/testdata/clang-386-darwin-exec-with-rpath
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.1_11.go
./cmd/vendor/golang.org/x/sys/unix/asm_darwin_386.s
./cmd/vendor/golang.org/x/sys/unix/zerrors_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/syscall_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.s
./cmd/vendor/golang.org/x/sys/unix/zsysnum_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/ztypes_darwin_386.go
./syscall/asm_darwin_386.s
./syscall/zerrors_darwin_386.go
./syscall/syscall_darwin_386.go
./syscall/zsyscall_darwin_386.s
./syscall/zsysnum_darwin_386.go
./syscall/zsyscall_darwin_386.go
./syscall/ztypes_darwin_386.go

But also stuff in ~~debug/macho~~ (see below comment), cmd/link, etc.

The text was updated successfully, but these errors were encountered:

ianlancetaylor · 2020-03-02T22:20:23Z

Just a note that I don't think we should remove any 386 support from debug/macho. The debug/macho package is for analyzing Mach-O files, and we should continue to support examining Mach-O 386 files even if we can no longer generate them.

andybons · 2020-03-02T22:37:08Z

@ianlancetaylor sgtm. Thanks for the note.

FiloSottile · 2020-04-03T03:59:12Z

Can we drop the darwin/386 builders from tip? I am failing them in CL 227037 but it's not worth fixing them since we are dropping the target.

gopherbot · 2020-04-03T05:46:48Z

Change https://golang.org/cl/226985 mentions this issue: cmd/dist: remove darwin/386 as a valid port

gopherbot · 2020-04-04T03:23:51Z

Change https://golang.org/cl/227181 mentions this issue: dashboard: update misc-compile--darwin description

dmitshur · 2020-04-04T03:30:35Z

@FiloSottile Yes, we should stop running those builders on tip (but they should still run on 1.14 and older release branches).

The misc-compile-darwin builder get its list of exact GOOS/GOARCH pairs from go tool dist list output (see here and here). So it'll stop being tested on as soon as darwin/386 is removed from tip.

I see @bradfitz already sent CL 226985 for that. If you want, you could rebase your CL on top to test it.

This only removes the ability to build it, and removes it as a src/buildall.bash target (which uses go tool dist list). Now: $ go tool dist list | grep ^darwin darwin/amd64 darwin/arm64 After this, remaining is removing leftover port--specific code in the tree. Updates #37610 Updates #37611 Change-Id: I00f03b2355c2e152f75e57abd3063be243529d2d Reviewed-on: https://go-review.googlesource.com/c/go/+/226985 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>

The 32-bit pairs darwin/386 and darwin/arm are removed in Go 1.15, and the master branch is where Go 1.15 is being developed. The builder has started to fail after CL 226985 (as intended), so remove it. Keep it running on Go 1.14 and 1.13 release branches. Also update the misc-compile-darwin builder description. For golang/go#37610. For golang/go#37611. Change-Id: Ia70386c5ae2821b4397048dcb0862a066463d6de Reviewed-on: https://go-review.googlesource.com/c/build/+/227181 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>

gopherbot · 2020-04-08T16:22:34Z

Change https://golang.org/cl/227582 mentions this issue: all: remove scattered remnants of darwin/386

gopherbot · 2020-04-08T16:22:35Z

Change https://golang.org/cl/227581 mentions this issue: all: remove darwin/386 build-tags and files

This removes all files that are only used on darwin/386 and cleans up build tags in files that are still used on other platforms. Updates #37610. Change-Id: If246642476c12d15f59a474e2b91a29c0c02fe75 Reviewed-on: https://go-review.googlesource.com/c/go/+/227581 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

gopherbot · 2020-04-09T00:27:24Z

Change https://golang.org/cl/227552 mentions this issue: go/packages: exclude darwin port from TestSizes test

gopherbot · 2020-04-09T15:12:21Z

Change https://golang.org/cl/227763 mentions this issue: [dev.link] cmd/link: delete darwin/386 host object loading support

gopherbot · 2020-04-09T15:36:06Z

Change https://golang.org/cl/227766 mentions this issue: cmd/oldlink: delete darwin/386 host object loading support

In Go 1.15, the darwin/386 port is gone. Updates #37610. Change-Id: I11627c03403d4d4a3e0950fdedd0d850ae24b439 Reviewed-on: https://go-review.googlesource.com/c/go/+/227766 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

In Go 1.15, the darwin/386 port is gone. Updates #37610. Change-Id: I308561848d90d9a649b3603ab1f7fc1117305ec1 Reviewed-on: https://go-review.googlesource.com/c/go/+/227763 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>

The darwin/386 port has been removed per golang.org/issue/37610. TestSizes needs an operating system that has both amd64 and 386 ports, so darwin no longer qualifies. NetBSD has had its 386 port restored recently in golang/go#31726, so it can be used instead. Fixes golang/go#38319. For golang/go#37610. Change-Id: I37ce6d86ca3ddad43e9294e0de66f36091cba54a Reviewed-on: https://go-review.googlesource.com/c/tools/+/227552 Reviewed-by: Benny Siegert <bsiegert@gmail.com>

gopherbot · 2020-04-22T14:17:25Z

Change https://golang.org/cl/229323 mentions this issue: [dev.link] cmd/link, cmd/oldlink: remove remaining darwin/386 and darwin/arm code

…rm code Updates #37610, #37611. Change-Id: I0a497af03e24ddea40ed3e342f3a9362bf21ac0c Reviewed-on: https://go-review.googlesource.com/c/go/+/229323 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com>

…rm code Updates golang#37610, golang#37611. Change-Id: I0a497af03e24ddea40ed3e342f3a9362bf21ac0c Reviewed-on: https://go-review.googlesource.com/c/go/+/229323 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com>

See golang/go#37610

Removed in go1.15 (GH/golang/go/issues/37610). Signed-off-by: Stephen Augustus <saugustus@vmware.com>

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

Remove darwin/386 due to golang/go#37610

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

Go 1.15 drops support for darwin/386 GOOS/GOARCH pair [1]. So, we have to skip this pair, and thus cannot use simple os multiply arch anymore. Switch to goxc's BuildConstraints config, which uses the same syntax as Go's build constraint header [2]. [1] golang/go#37610 [2] https://golang.org/cmd/go/#hdr-Build_constraints

andybons added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 2, 2020

andybons added this to the Go1.15 milestone Mar 2, 2020

andybons self-assigned this Mar 2, 2020

andybons assigned aclements and unassigned andybons Mar 9, 2020

sthagen mentioned this issue Apr 4, 2020

cmd/dist: remove darwin/386, darwin/arm as valid ports sthagen/golang-go#223

Merged

gopherbot closed this as completed in d5e1b7c Apr 8, 2020

dmitshur mentioned this issue Apr 9, 2020

x/tools/go/packages: TestSizes is failing on tip because darwin/386 port was removed #38319

Closed

odino mentioned this issue Aug 14, 2020

Go removed darwin/386 abs-lang/abs#396

Merged

sebbalex mentioned this issue Aug 18, 2020

GoReleaser is failing because of goos/goarch removal italia/publiccode-parser-go#50

Closed

xiaq mentioned this issue Aug 19, 2020

Support for darwin/386 elves/elvish#1118

Closed

eclipseo added a commit to eclipseo/go-daemon that referenced this issue Aug 23, 2020

Remove "darwin/386" pair as it has been obsoleted in Go 1.15

4575a85

See golang/go#37610

eclipseo mentioned this issue Aug 23, 2020

Remove "darwin/386" pair as it has been obsoleted in Go 1.15 sevlyar/go-daemon#69

Merged

ianlancetaylor mentioned this issue Oct 6, 2020

x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported #41829

Closed

sharadg pushed a commit to sharadg/kubernetes that referenced this issue Oct 23, 2020

[go1.15] Remove client support for darwin/386

8a149ba

Removed in go1.15 (GH/golang/go/issues/37610). Signed-off-by: Stephen Augustus <saugustus@vmware.com>

zquestz added a commit to gcash/bchd that referenced this issue Oct 24, 2020

darwin/386 support was removed in Go 1.15 - golang/go#37610

d387f82

matthewkmayer mentioned this issue Oct 27, 2020

Go 1.15: darwin/386 is no longer supported gomicro/probe#15

Closed

This was referenced Nov 30, 2020

Documented build process fails for vault plugin with current golang 1.15 ibm-cloud-security/vault-plugin-auth-ibmcloud#3

Closed

Documented build process fails for vault plugin with current golang 1.15 ibm-cloud-security/vault-plugin-secrets-ibmcloud#4

Closed

asannikov mentioned this issue Jan 10, 2021

tool throws an error "Binary files are not found. Run build command instead" jkawamoto/fgo#16

Open

johnboyes added a commit to agilepathway/gauge-jira that referenced this issue Jan 16, 2021

Remove darwin/386 from supported platforms

108cc9b

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

johnboyes added a commit to agilepathway/gauge-jira that referenced this issue Jan 16, 2021

Remove darwin/386 from supported platforms

77d8fe4

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

johnboyes added a commit to agilepathway/gauge-jira that referenced this issue Jan 16, 2021

Remove darwin/386 from supported platforms

7c891a8

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

bengadbois added a commit to bengadbois/pewpew that referenced this issue Jan 20, 2021

CI: update to go 1.15, update targets

8c47f52

Remove darwin/386 due to golang/go#37610

bengadbois mentioned this issue Jan 20, 2021

CI: update to go 1.15, update targets bengadbois/pewpew#44

Merged

bengadbois added a commit to bengadbois/pewpew that referenced this issue Jan 20, 2021

CI: update to go 1.15, update targets (#44)

f61bbbd

Remove darwin/386 due to golang/go#37610

johnboyes added a commit to agilepathway/gauge-jira that referenced this issue Feb 1, 2021

Remove darwin/386 from supported platforms

21dec11

[Go no longer supports darwin/386 (MacOS 32-bit apps), as of Go 1.15][1] [1]: golang/go#37610

mrutkows mentioned this issue Feb 12, 2021

Remove unsupported Darwin-386 (32-bit) from GoLang 1.15 build matrix apache/openwhisk-wskdeploy#1115

Merged

suleymanakbas91 mentioned this issue Mar 11, 2021

Don't release CLI binaries for Darwin-386 kyma-project/cli#803

Merged

peat-psuwit mentioned this issue Mar 24, 2021

.goxc.json: list os/arch explicitly to avoid darwin/386 aptly-dev/aptly#947

Merged

6 tasks

ibnesayeed mentioned this issue Apr 2, 2021

Crossbuild script produces incomplete results with invalid architectures oduwsdl/MemGator#135

Closed

johejo mentioned this issue Apr 9, 2021

Update to go1.16 and drop darwin/386 support sqldef/sqldef#107

Merged

golang locked and limited conversation to collaborators Apr 22, 2021

gopherbot added the FrozenDueToAge label Apr 22, 2021

rsc unassigned aclements Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: remove darwin/386 #37610

all: remove darwin/386 #37610

andybons commented Mar 2, 2020 •

edited

Loading

ianlancetaylor commented Mar 2, 2020

andybons commented Mar 2, 2020

FiloSottile commented Apr 3, 2020 •

edited by dmitshur

Loading

gopherbot commented Apr 3, 2020

gopherbot commented Apr 4, 2020

dmitshur commented Apr 4, 2020

gopherbot commented Apr 8, 2020

gopherbot commented Apr 8, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 22, 2020

all: remove darwin/386 #37610

all: remove darwin/386 #37610

Comments

andybons commented Mar 2, 2020 • edited Loading

ianlancetaylor commented Mar 2, 2020

andybons commented Mar 2, 2020

FiloSottile commented Apr 3, 2020 • edited by dmitshur Loading

gopherbot commented Apr 3, 2020

gopherbot commented Apr 4, 2020

dmitshur commented Apr 4, 2020

gopherbot commented Apr 8, 2020

gopherbot commented Apr 8, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 9, 2020

gopherbot commented Apr 22, 2020

andybons commented Mar 2, 2020 •

edited

Loading

FiloSottile commented Apr 3, 2020 •

edited by dmitshur

Loading