Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing documentation of quoting the URL of url.Errors in go1.14 release notes [1.14 backport] #37630

Closed
gopherbot opened this issue Mar 3, 2020 · 5 comments
Closed

doc: missing documentation of quoting the URL of url.Errors in go1.14 release notes [1.14 backport] #37630

gopherbot opened this issue Mar 3, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.14.1

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #37614 to be considered for backport to the next 1.14 minor release.

This needs to be fixed on master branch first, then it can be backported to Go 1.14.x.

@gopherbot Please open a backport issue for Go 1.14; this is a documentation fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 3, 2020
@gopherbot gopherbot mentioned this issue Mar 3, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.1 milestone Mar 3, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Mar 3, 2020

Approving because this is a documentation fix, which is in line with the backporting policy.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 3, 2020
@stefanb stefanb mentioned this issue Mar 6, 2020
Closed
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/222037 mentions this issue: doc/go1.14: document that unparsable URL in net/url.Error is now quoted

gopherbot pushed a commit that referenced this issue Mar 6, 2020
@stefanb @ianlancetaylor
doc/go1.14: document that unparsable URL in net/url.Error is now quoted
2b0f481 
Fixes #37614
Updates #36878
Updates #29384
Updates #37630

Change-Id: I63dad8b554353197ae0f29fa2a84f17bffa58557
GitHub-Last-Rev: 5297df3
GitHub-Pull-Request: #37661
Reviewed-on: https://go-review.googlesource.com/c/go/+/222037
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/222317 mentions this issue: [release-branch.go1.14] doc/go1.14: document that unparsable URL in net/url.Error is now quoted

@gopherbot
Copy link
Contributor Author

Closed by merging 0e9f7ac to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Mar 6, 2020
@stefanb @ianlancetaylor
[release-branch.go1.14] doc/go1.14: document that unparsable URL in n…
0e9f7ac 
…et/url.Error is now quoted

Updates #37614
Updates #36878
Updates #29384
Fixes #37630

Change-Id: I63dad8b554353197ae0f29fa2a84f17bffa58557
GitHub-Last-Rev: 5297df3
GitHub-Pull-Request: #37661
Reviewed-on: https://go-review.googlesource.com/c/go/+/222037
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 2b0f481)
Reviewed-on: https://go-review.googlesource.com/c/go/+/222317
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@stefanb
Copy link
Contributor

stefanb commented Mar 20, 2020

Now published live at https://golang.org/doc/go1.14#net/url

@NickyMateev NickyMateev mentioned this issue May 4, 2020
Merged
@golang golang locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
3 participants
@stefanb @dmitshur @gopherbot