Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestSizes is failing on tip because darwin/386 port was removed #38319

Closed
dmitshur opened this issue Apr 9, 2020 · 1 comment
Closed

x/tools/go/packages: TestSizes is failing on tip because darwin/386 port was removed #38319

dmitshur opened this issue Apr 9, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 9, 2020

The darwin/386 port was removed from tip per issue #37610. The TestSizes test is failing:

$ gotip test
--- FAIL: TestSizes (0.08s)
    --- FAIL: TestSizes/GOPATH (0.03s)
        packages_test.go:1610: err: exit status 2: stderr: cmd/go: unsupported GOOS/GOARCH pair darwin/386
            
    --- FAIL: TestSizes/Modules (0.05s)
        packages_test.go:1610: err: exit status 2: stderr: cmd/go: unsupported GOOS/GOARCH pair darwin/386
            
FAIL
exit status 1
FAIL	golang.org/x/tools/go/packages	40.795s

Spotted on build.golang.org.

/cc @matloob per owners.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository. labels Apr 9, 2020
@dmitshur dmitshur added this to the Unreleased milestone Apr 9, 2020
@dmitshur dmitshur self-assigned this Apr 9, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227552 mentions this issue: go/packages: exclude darwin port from TestSizes test

@golang golang locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot