Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: panic on misformed If-None-Match Header with http.ServeContent [1.14 backport] #39920

Closed
gopherbot opened this issue Jun 29, 2020 · 5 comments
Closed

net/http: panic on misformed If-None-Match Header with http.ServeContent [1.14 backport] #39920

gopherbot opened this issue Jun 29, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.6

Comments

@gopherbot
Copy link
Contributor

@networkimprov requested issue #39817 to be considered for backport to the next 1.14 minor release.

@gopherbot please backport to 1.14. CL at https://golang.org/cl/240343
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 29, 2020
@gopherbot gopherbot mentioned this issue Jun 29, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.5 milestone Jun 29, 2020
@networkimprov
Copy link

@dmitshur this may also need a 1.13 backport.

cc @FiloSottile @bradfitz

@FiloSottile
Copy link
Contributor

Opened #39925

@dmitshur
Copy link
Contributor

Backport approved for Go 1.14 (this issue) and 1.13 (#39925) as this is a serious issue with no workaround.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 11, 2020
@dmitshur dmitshur mentioned this issue Jul 11, 2020
Closed
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/240343 mentions this issue: [release-branch.go1.14] net/http: fix panic with If-None-Match value in http.ServeContent

gopherbot pushed a commit that referenced this issue Jul 13, 2020
@mraerino @dmitshur
[release-branch.go1.14] net/http: fix panic with If-None-Match value …
de0e241 
…in http.ServeContent

Updates #39817.
Fixes #39920.

Change-Id: I79f2ad7c836a8a46569f603aca583fdd526d22dc
GitHub-Last-Rev: 5b88aad
GitHub-Pull-Request: #39821
Reviewed-on: https://go-review.googlesource.com/c/go/+/239699
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit ce81a8f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/240343
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@gopherbot
Copy link
Contributor Author

Closed by merging de0e241 to release-branch.go1.14.

@andybons andybons modified the milestones: Go1.14.5, Go1.14.6 Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.6
Development

No branches or pull requests
5 participants
@andybons @networkimprov @FiloSottile @dmitshur @gopherbot