Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: update to freebsd-{amd64,386}-11_2 builder for 1.15 RC 2+ #40563

Closed
dmitshur opened this issue Aug 4, 2020 · 3 comments
Closed

x/build/cmd/release: update to freebsd-{amd64,386}-11_2 builder for 1.15 RC 2+ #40563

dmitshur opened this issue Aug 4, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD release-blocker
Milestone
Go1.15

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 4, 2020

The cmd/release command is currently configured to use the freebsd-{amd64,386}-11_1 builders for the freebsd release targets.

However, we've documented that Go 1.13 onwards requires at least FreeBSD 11.2 (see https://golang.org/doc/go1.13#freebsd):

As announced in the Go 1.12 release notes, Go 1.13 now requires FreeBSD 11.2 or later; support for previous versions has been discontinued. FreeBSD 12.0 or later requires a kernel with the COMPAT_FREEBSD11 option set (this is the default).

The build dashboard is correctly configured not to test Go 1.13+ commits on freebsd-{amd64,386}-11_1 builders. Luckily, the freebsd-amd64-race still uses FreeBSD 11.1 and does run on new Go commits, so we have test coverage from that. We also have test coverage from freebsd-{amd64,386}-11_2 builders, and they're passing. In summary:

  • FreeBSD 11.1 and older builders are disabled, no supported Go commits are tested (source).
    • Build status is unknown.
  • FreeBSD 11.2 and newer builders are enabled and test supported Go commits (source).
    • Builds are passing.
  • freebsd-amd64-race builder uses FreeBSD 11.1 and tests supported Go commits (source).
    • Builds are passing.

It would've been better if we caught and fixed this earlier, but given there will soon be an RC 2, we can fix this now. In the unlikely case the change of builder causes FreeBSD-specific regressions in RC 2 (despite passing builders), we can consider going back to the previous builder. FreeBSD is not a first class port and this change is outside of tree (which is why I'm not asking for a freeze exception), so it seems in scope. I'll apply release-blocker label because the fix is small and we should get it in if we don't learn something new suggesting otherwise. I'll send a CL.

I filed #40561 so we don't forget during future cycles, and do this at a better time.

/cc @golang/osp-team
@dmitshur dmitshur added OS-FreeBSD Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Aug 4, 2020
@dmitshur dmitshur added this to the Go1.15 milestone Aug 4, 2020
@dmitshur dmitshur self-assigned this Aug 4, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/246597 mentions this issue: cmd/release: start using FreeBSD 11.2 builders for Go 1.15 RC 2+

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/246638 mentions this issue: dashboard: re-enable FreeBSD 11.1 builders on Go 1.14 and 1.13

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/246639 mentions this issue: dashboard: remove obsolete disabled builders

gopherbot pushed a commit to golang/build that referenced this issue Aug 4, 2020
@dmitshur
dashboard: re-enable FreeBSD 11.1 builders on Go 1.14 and 1.13
246beb7 
These builders are still used for making minor Go 1.14 and 1.13
releases at this time (see golang.org/issue/40563). Re-enable
them on relevant release branches so that we are better informed
for future minor releases.

For golang/go#40563.
Updates golang/go#40562.

Change-Id: I20a6becbdb1078b92dbf6042edca7f482bca6432
Reviewed-on: https://go-review.googlesource.com/c/build/+/246638
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 4, 2020
@dmitshur
dashboard: remove obsolete disabled builders
0768812 
FreeBSD 9.3, FreeBSD 10.x, and OpenBSD 6.0 have
reached end-of-life and are no longer supported.
Go 1.12 was the last release¹ that ran on FreeBSD 10.x.
Go 1.10 was the last release² that ran on OpenBSD 6.0.

These builders have long since been disabled and won't be needed in
the future, so remove them. This work helped detect golang/go#40563.

Modify TestHostConfigsAllUsed to report errors instead of warnings
when it finds unused host configs. Make a map of known exceptions
with rationale or a linked issue for each entry.

¹ https://golang.org/doc/go1.12#ports
² https://golang.org/doc/go1.10#ports

Updates golang/go#36841.
Updates golang/go#19938.

Change-Id: Id7fcdc671bfacf7e70174f4168c9c9cc46ba53d7
Reviewed-on: https://go-review.googlesource.com/c/build/+/246639
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur dmitshur mentioned this issue Oct 30, 2020
Closed
@golang golang locked and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot