x/tools/gopls: bad error messages when changing package names

[stamblerre]

Repro case:

-- go.mod --
module mod.com
-- foo/foo.go --
package foo
-- foo/bar_test.go --
package foo_

Modifying foo/bar_test.go to contain package foo_test results in bad error messages (it doesn't recover from expecting that its name is foo_.

[pjweinb]

Is this a duplicate of #38866?

[stamblerre]

Possibly, but I think there are also issues with transitioning from a regular package to an x test.

[jeanbza]

I've got a repro based on the above testcase, and will start taking a peek soon. Is anyone else working on this, though? Don't want to step on toes. =)

(if I hear nothing back I'll continue as if the answer to that is a "no")

[pjweinb]

Go right ahead. i was going to look at #38866 but there's other things to do.

[gopherbot]

Change https://golang.org/cl/262019 mentions this issue: x/tools/gopls: add a skipped test for renaming of package

[jeanbza]

@pjweinb After a couple fridays afternoons of 20%ing, I unfortunately didn't get enough traction. This one appears to require a lot of institutional knowledge. 🙂 📚 Per @stamblerre suggestion I've parked the test that I wrote at https://go-review.googlesource.com/c/tools/+/262019, which I believe exercises this, but I'll take the pragmatic approach of dropping off this one and trying out an easier feature.

Sincere apologies if I wasted anyone's time trying to tackle this!!

[gopherbot]

Change https://golang.org/cl/274533 mentions this issue: gopls/internal/regtest: TestRenamePackage passes with go 1.16

[stamblerre]

Let's close this now that the test has been enabled.