Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: ref/mod go.mod section has broken ids #41080

Closed
seankhliao opened this issue Aug 27, 2020 · 3 comments
Closed

x/website: ref/mod go.mod section has broken ids #41080

seankhliao opened this issue Aug 27, 2020 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@seankhliao
Copy link
Member

What version of Go are you using (go version)?

current website

Does this issue reproduce with the latest release?

repros with https://tip.golang.org/ref/mod

What operating system and processor architecture are you using (go env)?

Google Chrome | 85.0.4183.83

What did you do?

visit https://golang.org/ref/mod and click on the require directive link in table of contents

What did you expect to see?

link/jump to "require directive" section

<h3 id="go.mod-require" class="mod-require"><code>require</code> directive</h3>

What did you see instead?

link/jump to "go.mod files" section

<h3 id="go" class="mod-require"><code>require</code> directive</h3>

additional info

it appears that the entire "go.mod files" section has their ids truncated to just go
@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2020
@seankhliao seankhliao changed the title x/website:ref/mod modfile directives have wrong id x/website: ref/mod go.mod section has broken ids Aug 27, 2020
@dmitshur
Copy link
Contributor

Thanks for the report.

/cc @jayconrod

@dmitshur dmitshur added Documentation Issues describing a change to documentation. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 31, 2020
@jayconrod
Copy link
Contributor

CL 248617 fixes this.

@bcmills @matloob Please review 🥺

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/248617 mentions this issue: content/static/doc: fix anchors with dots in module documentation

@golang golang locked and limited conversation to collaborators Sep 9, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static/doc: fix anchors with dots in module documentation
76a4198 
Our markdown renderer was cutting off everything after the dot, so
"go.mod-files" was rendered as "go".

For golang/go#33637
Fixes golang/go#41080

Change-Id: Iefded0f697c4c9c8833303e83de7317c3930091a
Reviewed-on: https://go-review.googlesource.com/c/website/+/248617
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jayconrod @dmitshur @gopherbot @seankhliao