-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: remove VZEROUPPER patch once Darwin <10.15.6 is not supported #41152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Apple has been making a new major macOS version each year, and Go has been dropping support for old macOS versions at the same rate. So we can estimate. Go 1.11 started to require macOS 10.10 or later. |
Potentially this issue was reintroduced (elsewhere?) in macOS 10.15.7 (19H15?): https://twitter.com/Cyan4973/status/1327023284974538754 |
For future self, make sure the reproducers in #37174 perform ok before removing the VZEROUPPER. |
Just upgraded to 10.15.7 and it looks still fixed to me. |
According to https://golang.org/doc/go1.16, Go 1.17 will still support macOS 10.13. So should this be deferred to Go 1.18 (or Go 1.23, per @dmitshur)? |
I understand this isn't so critical that we need to re-evaluate and bump every 6 months, so I'll put this in a future Go 1.23 milestone. If something changes before then, we can revisit this. |
This issue is currently labeled as early-in-cycle for Go 1.23. |
Change https://go.dev/cl/560955 mentions this issue: |
I could not find a Mac Intel for testing https://go-review.googlesource.com/c/go/+/560955, any help on verifying the CL is welcome. cc @golang/darwin |
Split out from #37174 (comment)
cc @randall77 @dmitshur
The text was updated successfully, but these errors were encountered: