Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "fatal error: unexpected signal during runtime execution" on windows-amd64-longtest builder of Go 1.15.2 commit [1.14 backport] #41322

Closed
dmitshur opened this issue Sep 10, 2020 · 5 comments
Closed

runtime: "fatal error: unexpected signal during runtime execution" on windows-amd64-longtest builder of Go 1.15.2 commit [1.14 backport] #41322

dmitshur opened this issue Sep 10, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14.10

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 10, 2020 •
edited
Loading

@mknyszek requested issue #41296 to be considered for backport to the next 1.14 minor release.

@gopherbot Ple​ase open a backport issue for 1.14.
@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Sep 10, 2020
@gopherbot gopherbot added this to the Go1.14.10 milestone Sep 10, 2020
@dmitshur dmitshur mentioned this issue Sep 10, 2020
Closed
@dmitshur
Copy link
Contributor Author

Approved as this is a test fix, needed to reduce false-positives during pre-release testing. This backport applies to both 1.15 (#41317) and 1.14 (this issue).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Sep 10, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/253922 mentions this issue: [release-branch.go1.14] runtime: fix ReadMemStatsSlow's and CheckScavengedBits' chunk iteration

@mknyszek
Copy link
Contributor

Ah, thank you! I'm sorry for not getting to it sooner.

@dmitshur
Copy link
Contributor Author

@mknyszek Not a problem!

@gopherbot
Copy link
Contributor

Closed by merging 3b364d9 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Sep 10, 2020
@mknyszek @dmitshur
[release-branch.go1.14] runtime: fix ReadMemStatsSlow's and CheckScav…
3b364d9 
…engedBits' chunk iteration

Both ReadMemStatsSlow and CheckScavengedBits iterate over the page
allocator's chunks but don't actually check if they exist. During the
development process the chunks index became sparse, so now this was a
possibility. If the runtime tests' heap is sparse we might end up
segfaulting in either one of these functions, though this will generally
be very rare.

The pattern here to return nil for a nonexistent chunk is also useful
elsewhere, so this change introduces tryChunkOf which won't throw, but
might return nil. It also updates the documentation of chunkOf.

For #41296.
Fixes #41322.

Change-Id: Id5ae0ca3234480de1724fdf2e3677eeedcf76fa0
Reviewed-on: https://go-review.googlesource.com/c/go/+/253777
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 34835df)
Reviewed-on: https://go-review.googlesource.com/c/go/+/253922
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14.10
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot