Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported #41829

Closed
ianlancetaylor opened this issue Oct 6, 2020 · 5 comments
Closed

x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported #41829

ianlancetaylor opened this issue Oct 6, 2020 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@ianlancetaylor
Copy link
Member

On https://golang.org/cl/259903 I asked for a darwin-386 slowbot. I got one, but it doesn't work, presumably because the darwin/386 port has been removed (#37610).

It seems to me that asking for a darwin-386 slowbot should simply ignore the request rather than run a broken slowbot.

Thanks.

CC @dmitshur @cagedmantis
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 6, 2020
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Oct 6, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 6, 2020
@ianlancetaylor
Copy link
Member Author

Failing slowbot run: https://storage.googleapis.com/go-build-log/f8e55402/darwin-386-10_14_298c3ae5.log

@dmitshur dmitshur changed the title x/build: asking for darwin-386 slowbot gets a slowbot that does not work x/build/cmd/coordinator: asking for darwin-386 slowbot gets a slowbot that does not work Oct 7, 2020
@dmitshur dmitshur self-assigned this Oct 7, 2020
@dmitshur dmitshur mentioned this issue Oct 7, 2020
Open
@dmitshur
Copy link
Contributor

dmitshur commented Oct 7, 2020

Go 1.14 is still supported, and it supports the darwin/386 port. Once it becomes unsupported (i.e., in 4~ months), we will remove the darwin-386-10_14 builder and its slowbot alias.

There is a separate enhancement idea that we can do sooner. I filed #41831 about it.

@dmitshur dmitshur removed their assignment Oct 7, 2020
@dmitshur dmitshur modified the milestones: Backlog, Go1.17 Oct 7, 2020
@dmitshur dmitshur added early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 7, 2020
@dmitshur dmitshur changed the title x/build/cmd/coordinator: asking for darwin-386 slowbot gets a slowbot that does not work x/build/dashboard: remove darwin-386-10_14 builder when Go 1.14 stops being supported Oct 7, 2020
@ianlancetaylor
Copy link
Member Author

OK, thanks.

@gopherbot
Copy link
Contributor

This issue is currently labeled as early-in-cycle for Go 1.17.
That time is now, so a friendly reminder to look at it again.

@dmitshur dmitshur self-assigned this Feb 24, 2021
@dmitshur
Copy link
Contributor

Resolved in CL 293771.

@golang golang locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@dmitshur @ianlancetaylor @gopherbot