Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: the first write error on a connection will cause all subsequent write requests to fail blindly [1.14 backport] #42112

Closed
gopherbot opened this issue Oct 21, 2020 · 6 comments
Closed

x/net/http2: the first write error on a connection will cause all subsequent write requests to fail blindly [1.14 backport] #42112

gopherbot opened this issue Oct 21, 2020 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.11

Comments

@gopherbot
Copy link
Contributor

@bradfitz requested issue #39337 to be considered for backport to the next 1.14 minor release.

@gopherbot, please backport. I think this is pretty bad. (It bit us and there's no great workaround, short of disabling HTTP/2)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 21, 2020
@gopherbot gopherbot mentioned this issue Oct 21, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.11 milestone Oct 21, 2020
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Oct 23, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 23, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/266157 mentions this issue: [release-branch.go1.14] http2: close Transport connection on write errors

@gopherbot
Copy link
Contributor Author

Closed by merging 70d85028bad349e3b72df9fa3a5069e5e866d7e2 to release-branch.go1.14.

gopherbot pushed a commit to golang/net that referenced this issue Oct 29, 2020
@fraenkel @dmitshur
[release-branch.go1.14] http2: close Transport connection on write er…
70d8502 
…rors

When a new connection is created, and a write error occurs during the
initial exchange, the connection must be closed. There is no guarantee
that the caller will close the connection.

When a connection with an existing write error is used or being used, it
will stay in use until its read loop completes. Requests will continue
to use this connection and fail when writing its header. These
connections should be closed to force the cleanup in its readLoop.

Updates golang/go#39337.
For golang/go#42112.

Change-Id: I45e1293309e40629531f4cbb69387864f4f71bc2
Reviewed-on: https://go-review.googlesource.com/c/net/+/240337
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Trust: Damien Neil <dneil@google.com>
(cherry picked from commit f585440)
Reviewed-on: https://go-review.googlesource.com/c/net/+/266157
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Fraenkel <michael.fraenkel@gmail.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur
Copy link
Contributor

Reopening for updating bundled copy in the standard library.

@dmitshur dmitshur reopened this Oct 29, 2020
@dmitshur dmitshur reopened this Oct 29, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/266374 mentions this issue: [release-branch.go1.14] net/http: update bundled x/net/http2

gopherbot pushed a commit that referenced this issue Oct 30, 2020
@dmitshur
[release-branch.go1.14] net/http: update bundled x/net/http2
162b65e 
Bring in the change in CL 266157 with:

	go get -d golang.org/x/net@release-branch.go1.14
	go mod tidy
	go mod vendor
	go generate -run=bundle std

Updates #39337.
Fixes #42112.

Change-Id: Iefd0012369c7f0c58201256e29d21210cb9f2f7a
Reviewed-on: https://go-review.googlesource.com/c/go/+/266374
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor

Closed by merging 162b65e to release-branch.go1.14.

@dmitshur dmitshur self-assigned this Nov 2, 2020
@golang golang locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.11
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot