-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: register semantic tokens with textDocument/semanticTokens #42148
Comments
Change https://golang.org/cl/266497 mentions this issue: |
Change https://golang.org/cl/266479 mentions this issue: |
Leaving this open after https://golang.org/cl/266479 to track the deletion of the |
Leave the legacy names to handle old versions of the VS Code language client. Updates golang/go#42148 Change-Id: Ia3eeef9e792e502c5c8018698b9c0ea3a9b0dfe5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/266479 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Peter Weinberger <pjw@google.com>
Change https://golang.org/cl/270359 mentions this issue: |
We currently use
textDocument/semanticTokens/full
only, but the correct way istextDocument/semanticTokens
. We'll have to register semantic tokens both ways to avoid regressing, but we'll eventually be able to remove the multiple registration capabilities after the next VS Code Go release.This will depend on the release of the next version of the vscode-languageclient. See microsoft/language-server-protocol#1107 for context.
The text was updated successfully, but these errors were encountered: