encoding/xml: Marshal ignores ",chardata" fields not of type []byte

[gopherbot]

by philipp.schumann:

"What steps will reproduce the problem? What is the expected output? What do you
see instead?"

A float64 tagged as chardata gets unmarshaled just fine with no issues, however
marshaling such a thing results in empty node values:

http://play.golang.org/p/gMsuECdiFe

I'd assume that Marshal() should closely match Unmarshal()'s capabilities. Admittedly
"round-tripping" use-cases are rare, but still...

"Which compiler are you using?"

6g

"Which operating system are you using?"

Windows 7

"Which version are you using?"

1.0.3

[rsc]

Comment 1:

In marshal.go:
        switch finfo.flags & fMode {
        case fCharData:
            switch vf.Kind() {
            case reflect.String:
                Escape(p, []byte(vf.String()))
            case reflect.Slice:
                if elem, ok := vf.Interface().([]byte); ok {
                    Escape(p, elem)
                }
            }
            continue
The switch needs to invert all the cases that read.go's copyValue does.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 2:

Labels changed: added size-m.

[rsc]

Comment 3:

Labels changed: added suggested.

[gopherbot]

Comment 4 by vegacom:

I started working on this.
The missing field types are int, uint, float and bool:
http://tip.play.golang.org/p/pJbHVG5Fbq

[gopherbot]

Comment 5 by vegacom:

https://golang.org/cl/7106045/

[rsc]

Comment 6:

This issue was closed by revision 14bd52d.

Status changed to Fixed.