x/tools/gopls: gopls doesn't report errors when a return statement contains undeclared variable

[ShoshinNikita]

gopls version: v0.6.7

The bug was introduced in golang/tools@144d5ce. The minimal reproducible example:

package main

func foo() int {
	return x, nil // No errors, expected 'wrong number of return values (want 1, got 2)' and 'undeclared name: x'
}

func bar() {
	return 5 // No errors, expected 'no result values expected'
}

func main() {
}

If we add var x string before the return statement, all errors will appear.

[stamblerre]

Thank you for this report, but unfortunately, I'm not able to reproduce the issue. Can you please share your gopls logs? Information on how to capture them can be found here.

/cc @heschik

[findleyr]

I can reproduce, and will take a look.

[gopherbot]

Change https://golang.org/cl/302533 mentions this issue: internal/lsp/cache: tolerate analysis panics better

[gopherbot]

Change https://golang.org/cl/302689 mentions this issue: internal/lsp/cache: tolerate analysis panics better