x/tools/gopls: IWL progress report canceled and not marked as done #46930

stamblerre · 2021-06-25T18:08:38Z

In a test failure on https://golang.org/cl/330969, we got this log: https://storage.googleapis.com/go-build-log/37f9a8f6/linux-amd64-race_7069ae28.log.

Here are the relevant logs:

[Trace - 16:39:22.158 PM] Received request 'window/workDoneProgress/create - (14)'.
Params: {"token":"2673644565579601470"}


[Trace - 16:39:22.161 PM] Sending response 'window/workDoneProgress/create - (14)' in 3ms.
Result: 


[Trace - 16:39:22.163 PM] Received notification '$/cancelRequest'.
Params: {"id":14}

The token 2673644565579601470 never gets a Done. progress report, and it's listed as outstanding work when the test fails:

#### End Gopls Test Logs for "TestProgressBarErrors/singleton"
--- FAIL: TestProgressBarErrors (20.41s)
    --- FAIL: TestProgressBarErrors/singleton (20.00s)
        diagnostics_test.go:1539: waiting on:
            	Unmet: no outstanding work
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Error: "2021/06/25 16:39:21 copying workspace dir: /workd...
            	Info: "2021/06/25 16:39:21 go env for /workdir/tmp/gopls-...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 getting workspace dir: /workd...
            	Error: "2021/06/25 16:39:21 copying workspace dir: openin...
            	Error: "2021/06/25 16:39:21 errors loading workspace: /wo...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=5...
            	Info: "2021/06/25 16:39:22 go/packages.Load\n\tsnapshot=7...
            
            #### diagnostics:
            	go.mod (version 3):
            
            #### outstanding work:
            	!NO NAME(token: 2673644565579601470): 0.00
            #### completed work:
            	Error loading workspace: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	diagnosing opened files: 1
            	diagnosing changed files: 2
            	diagnosing saved files: 2
            	diagnosing files changed on disk: 2
            	Load: 2
        runner.go:310: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/diagnostics	269.024s
ok  	golang.org/x/tools/gopls/internal/regtest/misc	226.881s
ok  	golang.org/x/tools/gopls/internal/regtest/modfile	44.929s
ok  	golang.org/x/tools/gopls/internal/regtest/watch	52.971s
ok  	golang.org/x/tools/gopls/internal/regtest/workspace	86.820s
?   	golang.org/x/tools/gopls/release	[no test files]
ok  	golang.org/x/tools/gopls/test	115.662s
ok  	golang.org/x/tools/gopls/test/debug	24.212s
FAIL

/cc @findleyr

The text was updated successfully, but these errors were encountered:

bcmills · 2021-11-02T21:16:51Z

This test has a high error rate, and it runs on TryBots (https://storage.googleapis.com/go-build-log/30a82efc/linux-amd64-race_29baf629.log). To me, that makes it a release-blocker via #11811.

greplogs --dashboard -md -l -e 'FAIL: TestProgressBarErrors'

bcmills · 2021-11-02T21:20:26Z

Another TryBot: https://storage.googleapis.com/go-build-log/79024cf3/linux-amd64-race_01632e59.log

findleyr · 2021-11-02T21:20:26Z

Indeed. I'll fix or delete.

gopherbot · 2021-11-03T19:25:08Z

Change https://golang.org/cl/361156 mentions this issue: internal/regtest: skip TestProgressBarErrors: it is too flaky

Updates golang/go#46930 Change-Id: I7bfaccf6b632623218450532e82cbd0ff45f49b7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/361156 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org>

findleyr · 2021-11-05T17:54:02Z

Similar to #48773, this is still a bug, but no longer a release blocker now that the test is skipped :-/

findleyr · 2022-05-18T14:48:50Z

Per #50885, I think there's a real user-facing issue here, not just a test flake. We should carefully investigate how a dangling IWL progress report is possible.

gopherbot · 2022-06-01T21:05:54Z

Change https://go.dev/cl/409936 mentions this issue: internal/lsp/progress: detach context for all progress notifications

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 25, 2021

gopherbot added this to the Unreleased milestone Jun 25, 2021

stamblerre modified the milestones: Unreleased, gopls/v0.7.1 Jun 26, 2021

LeGEC mentioned this issue Jun 29, 2021

x/tools/gopls: TestResolveImportCycle is flaky #46773

Closed

stamblerre modified the milestones: gopls/v0.7.1, gopls/v0.7.2 Jul 26, 2021

stamblerre modified the milestones: gopls/v0.7.2, gopls/on-deck Sep 9, 2021

stamblerre self-assigned this Sep 10, 2021

stamblerre removed their assignment Oct 19, 2021

bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Nov 2, 2021

bcmills modified the milestones: gopls/on-deck, Go1.18 Nov 2, 2021

findleyr self-assigned this Nov 2, 2021

findleyr removed the release-blocker label Nov 5, 2021

findleyr mentioned this issue Dec 1, 2021

x/tools/gopls/internal/regtest/misc: TestGenerateProgress failures with "Unmet: no outstanding work" #49901

Closed

findleyr modified the milestones: Go1.18, gopls/v0.7.5 Dec 14, 2021

findleyr modified the milestones: gopls/v0.7.5, gopls/v0.8.0 Jan 4, 2022

findleyr modified the milestones: gopls/v0.8.0, gopls/v0.8.1 Feb 21, 2022

findleyr modified the milestones: gopls/v0.8.1, gopls/v0.8.2 Mar 7, 2022

findleyr modified the milestones: gopls/v0.8.2, gopls/on-deck Mar 24, 2022

findleyr added the gopls/testing label Apr 11, 2022

findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022

findleyr mentioned this issue May 10, 2022

x/tools/gopls: syntax error in go.mod blocks progress end notification #50885

Open

findleyr modified the milestones: gopls/later, gopls/v0.9.0 May 18, 2022

findleyr changed the title ~~x/tools/gopls: progress report canceled and not marked as done~~ x/tools/gopls: IWL progress report canceled and not marked as done May 18, 2022

gopherbot closed this as completed in golang/tools@76325da Jun 2, 2022

rsc unassigned findleyr Jun 23, 2022

golang locked and limited conversation to collaborators Jun 23, 2023

gopherbot added the FrozenDueToAge label Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: IWL progress report canceled and not marked as done #46930

x/tools/gopls: IWL progress report canceled and not marked as done #46930

stamblerre commented Jun 25, 2021

bcmills commented Nov 2, 2021

bcmills commented Nov 2, 2021

findleyr commented Nov 2, 2021

gopherbot commented Nov 3, 2021

findleyr commented Nov 5, 2021

findleyr commented May 18, 2022

gopherbot commented Jun 1, 2022

x/tools/gopls: IWL progress report canceled and not marked as done #46930

x/tools/gopls: IWL progress report canceled and not marked as done #46930

Comments

stamblerre commented Jun 25, 2021

bcmills commented Nov 2, 2021

bcmills commented Nov 2, 2021

findleyr commented Nov 2, 2021

gopherbot commented Nov 3, 2021

findleyr commented Nov 5, 2021

findleyr commented May 18, 2022

gopherbot commented Jun 1, 2022