Skip to content

x/build/cmd/gomote: add gomote session manager package #48735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
cagedmantis opened this issue Oct 1, 2021 · 3 comments
Closed
1 task done

x/build/cmd/gomote: add gomote session manager package #48735

cagedmantis opened this issue Oct 1, 2021 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Oct 1, 2021 •
edited
Loading

Add a component which manages gomote instances. This component should:

  • Manage the lifecycle of gomote sessions (handle timeouts)

This is a component of the project to revamp the security model used by gomote #47521
@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 1, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Oct 1, 2021
@cagedmantis cagedmantis mentioned this issue Oct 2, 2021
Closed
16 tasks
@cagedmantis cagedmantis changed the title x/build/cmd/gomote: add gomote manager component x/build/cmd/gomote: add gomote session manager package Nov 2, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/361097 mentions this issue: internal/coordinator/remote: refactor remote buildlet session

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/361096 mentions this issue: internal/coordinator/remote: copy existing remote buildlet management

gopherbot pushed a commit to golang/build that referenced this issue Nov 8, 2021
@cagedmantis
internal/coordinator/remote: copy existing remote buildlet management
d2ffd1a 
This change copies the remote buildlet session management logic from
the cmd/coordinator/remote.go file. This copies the existing
implementation without including the HTTP and SSH handlers which also
contain small portions of logic. This is the first step before
refactoring the implementation which will be used in the GRPC server.

Updates golang/go#48735

Change-Id: Idb26616ddb5494a8f96f8b66369e20f19f2871dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/361096
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2021
@cagedmantis
internal/coordinator/remote, buildlet: refactor remote buildlet session
3f88ebd 
This change refactors the existing remote buildlet session management
implementation. It implements logic which was originally found in the
HTTP handlers and moves it into a session manager. This change also
introduces a fake buildlet client intended to be used for testing when
additional functionality is added to the session pool.

Updates golang/go#48735

Change-Id: Ib7d66cefb9847cf2659e7049f707d78536fbbbea
Reviewed-on: https://go-review.googlesource.com/c/build/+/361097
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@cagedmantis
Copy link
Contributor Author

This issue has been edited. We no longer plan to manage SSH keys in the coordinator. We've shifted over to using certificates for authentication. This work has been completed.

@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot