Skip to content

x/build/cmd/gomote: add authentication to gomote client #48739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cagedmantis opened this issue Oct 1, 2021 · 5 comments
Closed

x/build/cmd/gomote: add authentication to gomote client #48739

cagedmantis opened this issue Oct 1, 2021 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

This tracks the adding of Identity Aware Proxy authentication (OATH2) to the gomote client.

This is a component of the project to revamp the security model used by gomote #47521
@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 1, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Oct 1, 2021
@cagedmantis cagedmantis mentioned this issue Oct 2, 2021
Closed
16 tasks
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/361194 mentions this issue: internal/iapclient: create

gopherbot pushed a commit to golang/build that referenced this issue Nov 4, 2021
@heschi
internal/iapclient: create
a9d68c9 
iapclient enables command-line, programmatic access to our IAP-protected
sites. For now, it's quite specific to the command-line case; we can
make it more flexible in the future if necessary.

There are no tests, because I have no idea how to write a meaningful
automated test of this code.

For golang/go#48739.

Change-Id: Ibbc33ae045c6e5b68eee34900fe0a791d3a48558
Reviewed-on: https://go-review.googlesource.com/c/build/+/361194
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/367535 mentions this issue: internal/iapclient: create configuration directory

gopherbot pushed a commit to golang/build that referenced this issue Nov 29, 2021
@cagedmantis
internal/iapclient: create configuration directory
a93d72f 
The configuration directory must be created before the token is stored
in it. This change ensures that the directory exists before attempting
to store the newly created token in it.

Updates golang/go#48739

Change-Id: I2db71485c166ba094e61690533849c33913a5530
Reviewed-on: https://go-review.googlesource.com/c/build/+/367535
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/371014 mentions this issue: internal/iapclient: use http.PostForm to send request

gopherbot pushed a commit to golang/build that referenced this issue Dec 16, 2021
@dmitshur
internal/iapclient: use http.PostForm to send request
8a82ef1 
It has identical behavior but makes the code shorter and easier
to see that it's just a form POST, rather than something custom.

Also cap the body size it's willing to read for error reporting.

(Spotted while reading over this code.)

For golang/go#48739.

Change-Id: I586925d1a0c7e9a7e1efc93d121337a16fcee725
Reviewed-on: https://go-review.googlesource.com/c/build/+/371014
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/397656 mentions this issue: cmd/gomote: add gomote GRPC client and authentication

@rsc rsc unassigned heschi Jun 23, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/422454 mentions this issue: internal/iapclient: switch TV OAuth flow

gopherbot pushed a commit to golang/build that referenced this issue Aug 10, 2022
@heschi
internal/iapclient: switch TV OAuth flow
671cb44 
Google is deprecating the OOB OAuth flow. Switch to TV.

For golang/go#48739.

Change-Id: Ica6800e985e425cd8733d5e31af16035a496c76d
Reviewed-on: https://go-review.googlesource.com/c/build/+/422454
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
3 participants
@cagedmantis @gopherbot @heschi