Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/wasm, cmd/link: Go 1.17.2 causes WASM builds to throw command line too long with many environment variables [1.16 backport] #49153

Closed
gopherbot opened this issue Oct 25, 2021 · 2 comments
Closed

misc/wasm, cmd/link: Go 1.17.2 causes WASM builds to throw command line too long with many environment variables [1.16 backport] #49153

gopherbot opened this issue Oct 25, 2021 · 2 comments
Labels
arch-wasm WebAssembly issues CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.10

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #49011 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport tracking issues.

This is a follow-up to the security fix included in Go 1.17.2 and 1.16.9 for issue #48797; without it some programs are unable to run.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 25, 2021
@gopherbot gopherbot mentioned this issue Oct 25, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.10 milestone Oct 25, 2021
@dmitshur dmitshur added arch-wasm WebAssembly issues CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 25, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/359400 mentions this issue: [release-branch.go1.16] cmd/link: increase reserved space for passing env on wasm

gopherbot pushed a commit that referenced this issue Oct 28, 2021
@neelance @dmitshur
[release-branch.go1.16] cmd/link: increase reserved space for passing…
9004433 
… env on wasm

On wasm, the wasm_exec.js helper passes the command line arguments and
environment variables via a reserved space in the wasm linear memory.
Increase this reserved space from 4096 to 8192 bytes so more environment
variables can fit into the limit.

Later, after https://golang.org/cl/350737 landed, we can switch to the
WASI interface for getting the arguments and environment. This would
remove the limit entirely.

Updates #49011.
Fixes #49153.

Change-Id: I48a6e952a97d33404ed692c98e9b49c5cd6b269b
Reviewed-on: https://go-review.googlesource.com/c/go/+/358194
Trust: Richard Musiol <neelance@gmail.com>
Run-TryBot: Richard Musiol <neelance@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 252324e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/359400
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 9004433 to release-branch.go1.16.

@golang golang locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.10
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot