-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev.boringcrypto: TestGoAMD64v1 broken at HEAD #49402
Comments
I vaguely recall boringcrypto verifies itself before executing? If so, this test modifies the binary which makes it fail to verify. |
Yes, that verification looks like the problem. With this patch:
It prints
Note that it succeeds on Darwin - the failure seems to be Linux-specific. |
I think boringcrypto is only enabled on Linux. On darwin it doesn't use boringcrypto. |
Change https://golang.org/cl/362654 mentions this issue: |
This test modifies a binary, which the FIPS integrity test doesn't like. Fixes #49402 Change-Id: I817d1f49e779ce1ea5f9477bf74e729e82b42875 Reviewed-on: https://go-review.googlesource.com/c/go/+/362654 Trust: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
Closing as fixed by CL 362654, where it was determined the test is incompatible with the dev.boringcrypto branch, and shouldn't be run. |
The
TestGoAMD64v1
test incmd/compile/internal/amd64
is currently broken in the dev.boringcrypto branch (as of https://golang.org/cl/361714):Presumably this is because linking boringcrypto requires some weird opcodes? Not entirely sure.
cc @randall77, who added this test.
The text was updated successfully, but these errors were encountered: