x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work #49902

bcmills · 2021-12-01T17:50:26Z

(This log is from the first ppc-aix failure, to avoid conflating other current sources of flakiness.)

--- FAIL: TestGCDetails (77.63s)
    --- FAIL: TestGCDetails/experimental (65.00s)
        codelens_test.go:343: waiting on:
            	Unmet: empty diagnostics for "main.go"
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Info: "2021/11/30 15:27:36 go env for /ramdisk8GB/workdir...
            	Info: "2021/11/30 15:27:37 go/packages.Load\n\tsnapshot=0...
            	Info: "2021/11/30 15:27:37 discovered missing identifiers...
            
            #### diagnostics:
            	main.go (version 1):
            		(4, 5): canInlineFunction(cost: 76)
            		(5, 13): escape()
            		(5, 13): escape(42 escapes to heap)
            
            #### outstanding work:
            	diagnosing changed files: 0.00
            #### completed work:
            	Load: 1
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
            	Toggling GC Details: 1
            	diagnosing opened files: 1
        runner.go:312: closing editor: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/codelens	105.946s

greplogs --dashboard -md -l -e 'FAIL: TestGCDetails .*\n(?:(?:\s+.*)?\n)*\s+#### outstanding work:\n\s+[^# ]' --since=2021-04-27

CC @findleyr

The text was updated successfully, but these errors were encountered:

bcmills · 2022-01-24T15:32:58Z

Looks like the failures over the past ~month have only been on plan9, modulo some openbsd failures attributable to #49209.

greplogs --dashboard -md -l -e 'FAIL: TestGCDetails .*\n(?:(?:\s+.*)?\n)*\s+#### outstanding work:\n\s+[^# ]' --since=2021-12-01 | grep -v '\-n2d'

2022-01-19T20:29:36-7c251d6-d1640d8/plan9-386-0intro
2022-01-13T17:30:17-68b574a-2423912/plan9-amd64-0intro
2022-01-12T00:12:10-d7a4bb4-9bce089/plan9-386-0intro
2022-01-11T18:17:05-d7a4bb4-a20724d/plan9-amd64-0intro
2022-01-11T17:13:50-d7a4bb4-1abe9c1/plan9-386-0intro
2022-01-06T16:22:21-4754748-f009910/plan9-386-0intro
2022-01-05T21:22:03-04daf88-2b39d86/plan9-386-0intro
2022-01-05T21:11:50-04daf88-88cafe0/plan9-386-0intro
2022-01-02T14:27:43-ee1ca4f-c886143/openbsd-386-70
2021-12-28T19:29:29-ee1ca4f-1242f43/openbsd-386-70
2021-12-09T16:59:48-27fc764-307d7c6/plan9-386-0intro
2021-12-08T18:30:00-3fca6a0-61011de/plan9-386-0intro

gopherbot · 2022-01-24T15:52:19Z

Change https://golang.org/cl/380496 mentions this issue: gopls/internal/regtest/codelens: use the test's deadline instead of a hard-coded timeout

… hard-coded timeout We may want to generalize this to have regtest.Run always derive the default timeout from the test's deadline. In the meantime, this is a more targeted fix for the specific timeout in TestGCDetails. Fixes golang/go#49902 (Maybe.) Change-Id: Ie15735dc7b0d462ec047d3f3d8a2eceeb4411fa0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/380496 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 1, 2021

gopherbot added this to the Unreleased milestone Dec 1, 2021

suzmue modified the milestones: Unreleased, gopls/unplanned Dec 2, 2021

bcmills changed the title ~~x/tools/gopls/internal/regtest/workspace: TestGCDetails timeouts with non-empty outstanding work~~ x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work Jan 24, 2022

gopherbot closed this as completed in golang/tools@135972e Jan 24, 2022

bcmills reopened this Jan 26, 2022

bcmills closed this as completed Jan 26, 2022

findleyr modified the milestones: gopls/unplanned, gopls/v0.8.0 Aug 14, 2022

golang locked and limited conversation to collaborators Aug 14, 2023

gopherbot added the FrozenDueToAge label Aug 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work #49902

x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work #49902

bcmills commented Dec 1, 2021

bcmills commented Jan 24, 2022

gopherbot commented Jan 24, 2022

x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work #49902

x/tools/gopls/internal/regtest/codelens: TestGCDetails timeouts with non-empty outstanding work #49902

Comments

bcmills commented Dec 1, 2021

bcmills commented Jan 24, 2022

gopherbot commented Jan 24, 2022