Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: building for iOS, but linking in object file built for macOS [1.16 backport] #50194

Closed
gopherbot opened this issue Dec 15, 2021 · 3 comments
Closed

runtime/race: building for iOS, but linking in object file built for macOS [1.16 backport] #50194

gopherbot opened this issue Dec 15, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.13

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #46931 to be considered for backport to the next 1.16 minor release.

@gopherbot please backport this to Go 1.16. This fixes a test currently failing on 1.16 branch.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 15, 2021
@gopherbot gopherbot mentioned this issue Dec 15, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.13 milestone Dec 15, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/372218 mentions this issue: [release-branch.go1.16] runtime/race: use race build tag on syso_test.go

@dmitshur
Copy link
Contributor

Approved as a test-only fix. Only 1.16 needs this backport, since the fix is already present in Go 1.17.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Dec 15, 2021
@gopherbot
Copy link
Contributor Author

Closed by merging 831d491 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Dec 21, 2021
@cherrymui @dmitshur
[release-branch.go1.16] runtime/race: use race build tag on syso_test.go
831d491 
All other test files in the runtime/race package have race build
tag, except syso_test.go. The test is only relevant if the race
detector is supported. So apply the build tag.

Updates #46931.
Fixes #50194.

Change-Id: Icdb94214d3821b4ccf61133412ef39b4d7cc7691
Reviewed-on: https://go-review.googlesource.com/c/go/+/331050
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Elias Naur <mail@eliasnaur.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit ed01cea)
Reviewed-on: https://go-review.googlesource.com/c/go/+/372218
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.13
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot