Skip to content

x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures with "Unmet: empty diagnostics" #51352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Feb 24, 2022 · 6 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures with "Unmet: empty diagnostics" #51352

bcmills opened this issue Feb 24, 2022 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.10.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 24, 2022 

--- FAIL: TestSumUpdateFixesDiagnostics (544.64s)
    --- FAIL: TestSumUpdateFixesDiagnostics/experimental (543.87s)
        modfile_test.go:842: waiting on:
            	Unmet: empty diagnostics for "go.mod"
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Info: "2022/02/24 04:27:21 go env for /tmp/workdir-host-l...
            	Error: "2022/02/24 04:27:21 go/packages.Load: err: exit s...
            	Error: "2022/02/24 04:27:21 initial workspace load failed...
            	Error: "2022/02/24 04:27:21 errors loading workspace: err...
            	Error: "2022/02/24 04:27:21 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:21 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:21 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:21 errors loading workspace: err...
            	Error: "2022/02/24 04:27:21 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:21 errors loading workspace: err...
            	Error: "2022/02/24 04:27:22 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:22 go/packages.Load: err: exit s...
            	Error: "2022/02/24 04:27:22 initial workspace load failed...
            	Error: "2022/02/24 04:27:22 workspace packages: diagnosin...
            	Error: "2022/02/24 04:27:22 errors loading workspace: err...
            	Error: "2022/02/24 04:27:22 go/packages.Load: err: exit s...
            	Error: "2022/02/24 04:27:22 initial workspace load failed...
            	Error: "2022/02/24 04:27:22 errors loading workspace: err...
            	Error: "2022/02/24 04:27:22 workspace packages: diagnosin...
            
            #### diagnostics:
            	go.mod (version 2):
            		(4, 0): go.sum is out of sync with go.mod: entry for example.com@v1.2.3 is missing. Please updating it by applying the quick fix.
            
            #### outstanding work:
            	Error loading workspace: 0.00
            #### completed work:
            	Running go mod tidy: 1
            	diagnosing opened files: 1
            	diagnosing changed files: 1
            	Updating go.sum: 1
            	diagnosing files changed on disk: 2
            	diagnosing saved files: 1
            	Load: 4
            	Setting up workspace: 1
            	diagnosing initial workspace load: 1
        runner.go:324: closing editor: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/modfile	578.270s

greplogs --dashboard -md -l -e 'FAIL: TestSumUpdateFixesDiagnostics .*(?:\n .*)*Unmet: empty diagnostics' --since=2022-02-02

2022-02-23T19:46:34-258e473-e534907/linux-amd64-wsl
2022-02-17T17:37:50-a317113-eaf0405/linux-amd64-wsl
2022-02-16T18:05:27-11109f6-a289e9c/linux-amd64-wsl

CC @findleyr @mengzhuo
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 24, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Feb 24, 2022

One notable thing about this builder is that its connection to proxy.golang.org is unreliable (see #42971).

I wonder if TestSumUpdateFixesDiagnostics is somehow failing to notice and propagate a failure to apply the fix due to a bad connection to the proxy. 🤔

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 24, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/on-deck Mar 7, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Apr 5, 2022

This does not appear to be specific to the -wsl builder.

greplogs --dashboard -md -l -e 'FAIL: TestSumUpdateFixesDiagnostics .*(?:\n .*)*Unmet: empty diagnostics' --since=2022-02-25

2022-04-03T23:48:16-153e30b-ba6df85/windows-arm64-11
2022-04-02T14:28:33-153e30b-8a816d5/linux-amd64-longtest

@bcmills
Copy link
Contributor Author

bcmills commented Apr 7, 2022

greplogs --dashboard -md -l -e 'FAIL: TestSumUpdateFixesDiagnostics .*(?:\n .*)*Unmet: empty diagnostics' --since=2022-04-04

2022-04-06T18:19:46-6731659-5bb2628/linux-amd64-wsl

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398699 mentions this issue: gopls/internal/regtest/modfile: temporarily skip TestSumUpdateFixesDiagnostics

@bcmills bcmills changed the title x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures with "Unmet: empty diagnostics" on linux-amd64-wsl x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures with "Unmet: empty diagnostics" Apr 7, 2022
gopherbot pushed a commit to golang/tools that referenced this issue Apr 7, 2022
gopls/internal/regtest/modfile: temporarily skip TestSumUpdateFixesDi…
7f10777 
…agnostics

This test is somewhat noisy on the builders.
I'd like to skip it until someone can look into it in more depth.

For golang/go#51352.

Change-Id: I2aa5c9c279807b57872324d84c1bb585cdf34d06
Reviewed-on: https://go-review.googlesource.com/c/tools/+/398699
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@findleyr findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022
@findleyr findleyr mentioned this issue Jul 14, 2022
Closed
8 tasks
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/423974 mentions this issue: gopls/internal/regtest: unskip TestSumUpdateFixesDiagnostics

gopherbot pushed a commit to golang/tools that referenced this issue Aug 15, 2022
@findleyr
gopls/internal/regtest: unskip TestSumUpdateFixesDiagnostics
8c83056 
Metadata reloading has been significantly refactored recently. Unskip
this test to see if it still flakes.

For golang/go#51352
For golang/go#53878

Change-Id: I9f2ae1835bbace1b5095c2d45db082c4e709437b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/423974
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
@findleyr
Copy link
Member 

> greplogs --dashboard -md -l -e 'FAIL: TestSumUpdateFixesDiagnostics .*' --since=2022-04-04
[2022-04-06T18:19:46-6731659-5bb2628/linux-amd64-wsl](https://build.golang.org/log/8e32fa76bbee76dbcbb454c15c253b87f04654e9)

Looks like this is no longer flaking. Closing.

@findleyr findleyr modified the milestones: gopls/later, gopls/v0.10.0 Oct 20, 2022
@golang golang locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.10.0
Development

No branches or pull requests
4 participants
@hyangah @bcmills @gopherbot @findleyr