Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln/cmd/govulncheck: TestCommand failures with mismatched exit codes and no other output #52410

Closed
bcmills opened this issue Apr 18, 2022 · 2 comments
Closed

x/vuln/cmd/govulncheck: TestCommand failures with mismatched exit codes and no other output #52410

bcmills opened this issue Apr 18, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 18, 2022

greplogs --dashboard -md -l -e 'FAIL: TestCommand/.*\n cmdtest\.go:.* failed with exit code \d+, but 3 was expected\nFAIL'

2022-04-16T11:17:39-506dc81-5e4543c/linux-mips64le-mengzhuo
2022-04-16T01:25:04-807ebe9-e704ef2/linux-amd64-wsl
2022-04-15T19:02:54-807ebe9-df08c9a/linux-mips64le-mengzhuo

The root cause of these failures is almost certainly due to problems with builder connectivity problems (#42971), but the error output from the test is not helpful in diagnosing it as such — it doesn't describe what actually went wrong with the invocation, and to me does not meet the Go standard for useful test failures.

It isn't clear to me whether this is due to the govulncheck command itself burying the errors, or due to the test itself (or the go-cmdtest package it uses) unexpectedly swallowing the stderr output in case of a mismatched exit code.

(attn @jba @zpavlinovic @julieqiu)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 18, 2022
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 18, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 18, 2022
@jba jba self-assigned this Apr 18, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/400358 mentions this issue: cmd/govulncheck: log command test output

gopherbot pushed a commit to golang/vuln that referenced this issue Apr 18, 2022
@jba
cmd/govulncheck: log command test output
4804c43 
Updates golang/go#52410.

Change-Id: I12863f0ccdd466aa976aa00f96f8a4e8fea9582c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/400358
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
@zpavlinovic
Copy link
Contributor

I believe this has been addressed. Closing for now.

@rsc rsc unassigned jba Jun 22, 2022
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
cmd/govulncheck: log command test output
f509aee 
Updates golang/go#52410.

Change-Id: I12863f0ccdd466aa976aa00f96f8a4e8fea9582c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/400358
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
cmd/govulncheck: log command test output
f3d4107 
Updates golang/go#52410.

Change-Id: I12863f0ccdd466aa976aa00f96f8a4e8fea9582c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/400358
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@zpavlinovic @bcmills @gopherbot @jba