-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: SecPolicyCreateSSL returns null when binary is called with strange path #54590
Comments
Crashes for me as well, running this on an Intel macOS.
Full panic output
|
I can only reproduce this with Go 1.18 and 1.19, not 1.17. Changed the title as it feels like the crash is in the |
It also fails with tip. I agree this looks like some obscure bug in crypto/x509. |
Change https://go.dev/cl/438135 mentions this issue: |
Extremely weird. This appears to be a macos bug(/behavior) in
The 'fix' on our end is relatively simple, and will resolve the panic, but it'll still fail when called this way. |
For histories sake, this appears to be triggered in particular by |
This still happens on go 1.20. It doesn't crash, it just returns invalid cert. |
There is nothing we can do other than failing gracefully, the ball is in Apples court. |
Understand that - is there a link to something on their end? |
Apple feedback tickets are typically not publicly available as far as I'm aware, that said the ID for my report to them is FB11643282 and there has been no response to it since I opened it last October. |
this was causing failures on MacOS becuase the path to the kilnfile was being cleared pre-maturely: golang/go#54590
this was causing failures on MacOS becuase the path to the kilnfile was being cleared pre-maturely: golang/go#54590
this was causing failures on MacOS becuase the path to the kilnfile was being cleared pre-maturely: golang/go#54590
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Running a compiled Go binary with a strange path causes crashes that are very similar to #51759, so perhaps the crash is rather in
crypto/x509
than innet/http
.I can only reproduce it when calling the Go binary with a path that includes a double slash
//
and a directory that starts with a dot.
. I have no idea why this is or how to further debug is.This reproducing script sets up a minimal folder structure, build the tool and runs it in a way that causes crashes:
Calling it e.g. with
$(pwd)/dir/../.dot/repro
,$(pwd)//.dot/repro
, or$(pwd)/.dot/repro
does not cause the same crash.What did you expect to see?
HTML output from https://google.com.
What did you see instead?
Panic, see hidden long panic text below:
Full panic output
/cc @bradfitz
as you reported the very similar ticket #51759, would be interesting to see if you can reproduce this the same way.
The text was updated successfully, but these errors were encountered: