Skip to content

x/build/cmd/coordinator: remove access to the legacy gomote implementation #54735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cagedmantis opened this issue Aug 29, 2022 · 5 comments
Closed

x/build/cmd/coordinator: remove access to the legacy gomote implementation #54735

cagedmantis opened this issue Aug 29, 2022 · 5 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

The security model and API for gomote have been changed (see #47521). This issue tracks the removal of the legacy implementation and user access to it.

@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 29, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Aug 29, 2022
@cagedmantis cagedmantis self-assigned this Aug 29, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/426015 mentions this issue: cmd/coordinator: check the session pool for buildlets

gopherbot pushed a commit to golang/build that referenced this issue Aug 29, 2022
@cagedmantis @gopherbot
cmd/coordinator: check the session pool for buildlets
5e298dc 
Remote buildlets should not be destroyed by the pool implementations for
instances which have been created on clouds. This change adds a check
to ensure that the pool implementations can check for remote buildlets
for instances which are managed by the session pools. Those sessions will
be destroyed by the session pool.

The buildlet client accessors for instance names have been changed so
that they are no longer GCE specific.

The EC2 session pool implementation has been changed so that the
instance name is set in the buildlet client when an EC2 instance is
created.

Updates golang/go#54735
Updates golang/go#54696

Change-Id: Iae3c86cc47b4b79e3287d581dc042dcf2714f7c9
Reviewed-on: https://go-review.googlesource.com/c/build/+/426015
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/430279 mentions this issue: all: remote legacy gomote API and SSH implementation

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/430695 mentions this issue: cmd/coordinator: add a handler for local development

gopherbot pushed a commit to golang/build that referenced this issue Sep 13, 2022
@cagedmantis
cmd/coordinator: add a handler for local development
7aa47da 
This change adds a handler which was mistakenly removed. The handler facilitates
local development.

Updates golang/go#54735

Change-Id: Ib1e8ca1ea9a3ee6471192e794975bbd5bf74428e
Reviewed-on: https://go-review.googlesource.com/c/build/+/430695
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456044 mentions this issue: cmd/gomote: remove legacy gomote functions

gopherbot pushed a commit to golang/build that referenced this issue Dec 12, 2022
@cagedmantis @gopherbot
cmd/gomote: remove legacy gomote functions
d86daaa 
This removes the functions which used the depricated gomote API.

Updates golang/go#54735
Updates golang/go#53272

Change-Id: I12d2ce823f140f510186109e2755cca8461a30b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/456044
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/499595 mentions this issue: internal/gophers: remove GitHubOfGomoteUser

gopherbot pushed a commit to golang/build that referenced this issue May 31, 2023
@dmitshur @gopherbot
internal/gophers: remove GitHubOfGomoteUser
756b7f5 
The new gomote SSH implementation doesn't rely on knowing the user's
GitHub account and its public SSH keys, there's no more need for the
GitHubOfGomoteUser function and its maintenance.

For golang/go#54735.
For golang/go#47521.

Change-Id: Ic35ad254d8cf8bbd0ef652bedbec7e6222bb1cd9
Reviewed-on: https://go-review.googlesource.com/c/build/+/499595
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot