x/tools/gopls: incorrectly detecting go version

[hyangah]

I just got this prompt when running a vscode-go integration test with v0.10.0-pre.3.

The log message I got:

[Trace - 10:25:39 PM] Received response 'initialize - (0)' in 58ms.
Result: {
    ...
    "serverInfo": {
        "name": "gopls",
        "version": "{\"GoVersion\":\"go1.19.1\",\"Path\":\"golang.org/x/tools/gopls\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"v0.10.0-pre.3\",... \"Replace\":null}...\"Version\":\"v0.10.0\"}"
    }
}

[Trace - 10:25:39 PM] Sending notification 'initialized'.
Params: {}
[Trace - 10:25:39 PM] Received notification 'window/showMessage'.
Params: {
    "type": 1,
    "message": "Found Go version 1.-1, which is not supported by this version of gopls. Please upgrade to Go 1.16 or later and reinstall gopls. If you can't upgrade and want this message to go away, please install gopls v0.7.5. See https://go.dev/s/gopls-support-policy for more details."
}
[Trace - 10:25:39 PM] Received request 'client/registerCapability - (1)'.
...
[Trace - 10:25:39 PM] Sending response 'client/registerCapability - (1)'. Processing request took 0ms
...
[Trace - 10:25:40 PM] Received request 'workspace/configuration - (3)'.
Params: {
    "items": [
        {
            "scopeUri": "file:///Users/hakim/projects/vscode-go/test/testdata/gogetdocTestData",
            "section": "gopls"
        }
    ]
}
[Trace - 10:25:40 PM] Sending response 'workspace/configuration - (3)'. Processing request took 2ms
Result: [
    {
        "ui.semanticTokens": true,
        "ui.codelenses": {
            "run_vulncheck_exp": true
        },
        "ui.inlayhint.hints": {
            "assignVariableTypes": false,
            "compositeLiteralFields": false,
            "compositeLiteralTypes": false,
            "constantValues": false,
            "functionTypeParameters": false,
            "parameterNames": true,
            "rangeVariableTypes": false
        },
        "allExperiments": true
    }
]

[Info  - 10:25:40 PM] 2022/10/27 22:25:40 go env for /Users/hakim/projects/vscode-go/test/testdata/gogetdocTestData
(root /Users/hakim/projects/vscode-go/test/testdata/gogetdocTestData)
(go version go version go1.19.2 darwin/amd64)
(valid build configuration = true)
(build flags: [])
GOMOD=/Users/hakim/projects/vscode-go/test/testdata/gogetdocTestData/go.mod
GOFLAGS=
GONOPROXY=
GOROOT=/usr/local/Cellar/go/1.19.2/libexec
...

I don't know how I ended up with -1 as my go version. Can be related to some peculiarity in the test setup.
According to the later info message (go env ...), it looks like gopls found go version correctly though.

cc @findleyr

[findleyr]

Thanks for catching this. https://go.dev/cl/445581 inadvertently removed handling for an undetected Go version.

Is it possible that in your test setup the go version would only be resolved after a didChangeConfiguration request?

[gopherbot]

Change https://go.dev/cl/446175 mentions this issue: gopls/internal: don't show a warning if the Go version is undetected

[gopherbot]

Change https://go.dev/cl/446235 mentions this issue: [gopls-release-branch.0.10] gopls/internal: don't show a warning if the Go version is undetected