Skip to content

x/tools/gopls: rename: handle generic methods more precisely #58462

Open
@adonovan

Description

@adonovan

gopls's renaming is tricky in the presence of generic methods, and our support for them is rudimentary. The challenge is in trying to decide which interfaces and methods correspond (and must be renamed together) when type parameters are involved. Recent changes to the renaming implementation for incrementalized type checking have not made things worse but have made us more aware of the problems and the paucity of testing generally. We should try to come up with a more comprehensive theory of how to do it. This isn't a regression so it needn't happen for v0.12.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    RefactoringIssues related to refactoring toolsToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.gopls/genericsIssues related to gopls' support for generics

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions