Skip to content

x/tools/gopls/internal/regtest/misc: TestRunVulncheckWarning failures #58709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 24, 2023 · 5 comments
Closed

x/tools/gopls/internal/regtest/misc: TestRunVulncheckWarning failures #58709

gopherbot opened this issue Feb 24, 2023 · 5 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunVulncheckWarning"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRunVulncheckWarning (0.54s)
    --- FAIL: TestRunVulncheckWarning/default (0.53s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 4642189030961894313" is met, must have:
            received ShowMessage

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2023/02/23 13:09:32 go info for C:\\Users\\gopher\...
            	Info: "2023/02/23 13:09:32 go/packages.Load #262\n\tsnaps...
            	Info: "2023/02/23 13:09:32 go/packages.Load #262: updatin...
            	Info: "2023/02/23 13:09:33 13:09:33 Loading packages...\n...
            	Info: "2023/02/23 13:09:33 fatal error: checkptr: convert...
            	Info: "2023/02/23 13:09:33 \ngoroutine 1 [running]:\nrunt...
            	Info: "2023/02/23 13:09:33  +0x53 fp=0xc000079fa0 sp=0xc0...
            	Info: "2023/02/23 13:09:33 os.Environ(...)\n\tC:/workdir/...
            	Info: "2023/02/23 13:09:33 ()\n\tC:/workdir/go/src/runtim...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 24, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunVulncheckWarning"
2023-02-23 13:00 windows-amd64-race tools@4906a71e go@ac556f35 x/tools/gopls/internal/regtest/misc.TestRunVulncheckWarning (log) 
--- FAIL: TestRunVulncheckWarning (0.54s)
    --- FAIL: TestRunVulncheckWarning/default (0.53s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 4642189030961894313" is met, must have:
            received ShowMessage

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2023/02/23 13:09:32 go info for C:\\Users\\gopher\...
            	Info: "2023/02/23 13:09:32 go/packages.Load #262\n\tsnaps...
            	Info: "2023/02/23 13:09:32 go/packages.Load #262: updatin...
            	Info: "2023/02/23 13:09:33 13:09:33 Loading packages...\n...
            	Info: "2023/02/23 13:09:33 fatal error: checkptr: convert...
            	Info: "2023/02/23 13:09:33 \ngoroutine 1 [running]:\nrunt...
            	Info: "2023/02/23 13:09:33  +0x53 fp=0xc000079fa0 sp=0xc0...
            	Info: "2023/02/23 13:09:33 os.Environ(...)\n\tC:/workdir/...
            	Info: "2023/02/23 13:09:33 ()\n\tC:/workdir/go/src/runtim...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunVulncheckWarning"
2023-02-27 20:01 windows-amd64-race tools@b0fcf2a0 go@ef793801 x/tools/gopls/internal/regtest/misc.TestRunVulncheckWarning (log) 
--- FAIL: TestRunVulncheckWarning (0.62s)
    --- FAIL: TestRunVulncheckWarning/default (0.61s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 3716200027760146469" is met, must have:
            received ShowMessage

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2023/02/28 02:14:22 go info for C:\\Users\\gopher\...
            	Info: "2023/02/28 02:14:22 go/packages.Load #260\n\tsnaps...
            	Info: "2023/02/28 02:14:22 go/packages.Load #260: updatin...
            	Info: "2023/02/28 02:14:22 02:14:22 Loading packages...\n...
            	Info: "2023/02/28 02:14:22 fatal error: checkptr: convert...
            	Info: "2023/02/28 02:14:22 \n\n\toperation=\"vulncheck\"\n"
            	Info: "2023/02/28 02:14:22 goroutine 1 [running]:\nruntim...
            	Info: "2023/02/28 02:14:22  pc=0x4b5b61\ncreated by runti...
            	Info: "2023/02/28 02:14:22 :1275 +0xf1 fp=0xc000385fe0 sp...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@findleyr
Copy link
Member

This is #58714

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunVulncheckWarning"
2023-03-01 16:36 windows-amd64-race tools@096bae8f go@bdd86bda x/tools/gopls/internal/regtest/misc.TestRunVulncheckWarning (log) 
serve.go:434: debug server listening at http://localhost:49779
serve.go:434: debug server listening at http://localhost:49780
#### Start Gopls Test Logs for "TestRunVulncheckWarning/default"
[Trace - 17:56:25.168 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-482831690\\TestRunVulncheckWarning\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-482831690/TestRunVulncheckWarning/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test1742394998","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-482831690/TestRunVulncheckWarning/default/work","name":"work"}]}


[Trace - 17:56:25.171 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunVulncheckWarning (0.62s)
    --- FAIL: TestRunVulncheckWarning/default (0.61s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 7973373337405914999" is met, must have:
            received ShowMessage

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@gopherbot gopherbot reopened this Mar 1, 2023
@findleyr
Copy link
Member

findleyr commented Mar 1, 2023

Still checkptr.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr