syscall: `Environ` uses an invalid `unsafe.Pointer` conversion on Windows #58714

bcmills · 2023-02-24T17:26:15Z

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

The pointer conversion on this line is invalid: it refers to a null-terminated string by a hard-coded array size.

	for from, i, p := 0, 0, (*[1 << 24]uint16)(unsafe.Pointer(s)); true; i++ {

The text was updated successfully, but these errors were encountered:

bcmills · 2023-02-24T17:26:43Z

(CC @golang/windows)

bcmills · 2023-02-24T17:27:29Z

(Pulled out from #55167 (comment).)

gopherbot · 2023-02-24T23:22:44Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

2023-02-15 21:45 windows-amd64-race tools@d87a1002 go@965e9ba0 x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125 (log)

fatal error: checkptr: converted pointer straddles multiple allocations

runtime.throw({0x1659b00?, 0x92601?})
	C:/workdir/go/src/runtime/panic.go:1047 +0x65 fp=0xc0005ed278 sp=0xc0005ed248 pc=0x47f6c5
runtime.checkptrAlignment(0x4b72d9?, 0x4b8df7?, 0x544a54?)
	C:/workdir/go/src/runtime/checkptr.go:26 +0x6c fp=0xc0005ed298 sp=0xc0005ed278 pc=0x44c16c
syscall.Environ()
	C:/workdir/go/src/syscall/env_windows.go:83 +0xcd fp=0xc0005ed398 sp=0xc0005ed298 pc=0x4cde2d
internal/syscall/execenv.Default(0x0)
	C:/workdir/go/src/internal/syscall/execenv/execenv_windows.go:26 +0x91 fp=0xc0005ed4c0 sp=0xc0005ed398 pc=0x53aa51
...
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:186 +0x51 fp=0xc0005edcb0 sp=0xc0005edc40 pc=0xe902d1
golang.org/x/tools/internal/testenv.NeedsGoPackages({0x19def88, 0xc000085520})
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:217 +0xbd fp=0xc0005edce0 sp=0xc0005edcb0 pc=0xe9063d
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000425ae0, 0xc000085520, {0x165b5d6, 0x3d}, 0x177d228, {0x0, 0x0, 0x0?})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:144 +0x9e fp=0xc0005ede50 sp=0xc0005edce0 pc=0x137597e
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:55
golang.org/x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/call_hierarchy_test.go:24 +0x5f fp=0xc0005edea8 sp=0xc0005ede50 pc=0x13e855f
testing.tRunner(0xc000085520, 0x177d230)

2023-02-16 18:08 windows-amd64-race tools@e5c9e631 go@7b398b1f x/tools/gopls/internal/regtest/misc.TestGovulncheckInfo (log)

serve.go:434: debug server listening at http://localhost:49783
serve.go:434: debug server listening at http://localhost:49784
#### Start Gopls Test Logs for "TestGovulncheckInfo/default"
[Trace - 18:20:08.072 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-3128659959\\TestGovulncheckInfo\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-3128659959/TestGovulncheckInfo/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test560910818","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-3128659959/TestGovulncheckInfo/default/work","name":"work"}]}


[Trace - 18:20:08.075 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestGovulncheckInfo (0.64s)
    --- FAIL: TestGovulncheckInfo/default (0.63s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 1414530661682718274" is met, must have:
            received ShowMessage

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1

2023-02-16 19:20 windows-amd64-race tools@e5b99481 go@7b398b1f x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125 (log)

fatal error: checkptr: converted pointer straddles multiple allocations

runtime.throw({0x165e00b?, 0x95901?})
	C:/workdir/go/src/runtime/panic.go:1047 +0x65 fp=0xc000367278 sp=0xc000367248 pc=0x47f6e5
runtime.checkptrAlignment(0x4b72f9?, 0x4b8e17?, 0x544a74?)
	C:/workdir/go/src/runtime/checkptr.go:26 +0x6c fp=0xc000367298 sp=0xc000367278 pc=0x44c16c
syscall.Environ()
	C:/workdir/go/src/syscall/env_windows.go:83 +0xcd fp=0xc000367398 sp=0xc000367298 pc=0x4cde4d
internal/syscall/execenv.Default(0x0)
	C:/workdir/go/src/internal/syscall/execenv/execenv_windows.go:26 +0x91 fp=0xc0003674c0 sp=0xc000367398 pc=0x53aa71
...
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:186 +0x51 fp=0xc000367cb0 sp=0xc000367c40 pc=0xe90391
golang.org/x/tools/internal/testenv.NeedsGoPackages({0x19e3da8, 0xc0002889c0})
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:217 +0xbd fp=0xc000367ce0 sp=0xc000367cb0 pc=0xe906fd
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc0002075e0, 0xc0002889c0, {0x165fae1, 0x3d}, 0x17817a0, {0x0, 0x0, 0x0?})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:144 +0x9e fp=0xc000367e50 sp=0xc000367ce0 pc=0x1378a1e
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:55
golang.org/x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/call_hierarchy_test.go:24 +0x5f fp=0xc000367ea8 sp=0xc000367e50 pc=0x13ebbdf
testing.tRunner(0xc0002889c0, 0x17817a8)

2023-02-22 21:51 windows-amd64-race tools@3ec30bd9 go@ac556f35 x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125 (log)

fatal error: checkptr: converted pointer straddles multiple allocations

runtime.throw({0x1670368?, 0xc4901?})
	C:/workdir/go/src/runtime/panic.go:1047 +0x65 fp=0xc0003dd278 sp=0xc0003dd248 pc=0x47f6e5
runtime.checkptrAlignment(0x4b72f9?, 0x4b8e17?, 0x544a74?)
	C:/workdir/go/src/runtime/checkptr.go:26 +0x6c fp=0xc0003dd298 sp=0xc0003dd278 pc=0x44c16c
syscall.Environ()
	C:/workdir/go/src/syscall/env_windows.go:83 +0xcd fp=0xc0003dd398 sp=0xc0003dd298 pc=0x4cde4d
internal/syscall/execenv.Default(0x0)
	C:/workdir/go/src/internal/syscall/execenv/execenv_windows.go:26 +0x91 fp=0xc0003dd4c0 sp=0xc0003dd398 pc=0x53aa71
...
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:186 +0x51 fp=0xc0003ddcb0 sp=0xc0003ddc40 pc=0xe9c3d1
golang.org/x/tools/internal/testenv.NeedsGoPackages({0x19f73c8, 0xc000410820})
	C:/workdir/gopath/src/golang.org/x/tools/internal/testenv/testenv.go:217 +0xbd fp=0xc0003ddce0 sp=0xc0003ddcb0 pc=0xe9c73d
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc0005a6c80, 0xc000410820, {0x1671e3e, 0x3d}, 0x1794700, {0x0, 0x0, 0x0?})
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:144 +0x9e fp=0xc0003dde50 sp=0xc0003ddce0 pc=0x13851be
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:55
golang.org/x/tools/gopls/internal/regtest/misc.TestCallHierarchy_Issue49125(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/misc/call_hierarchy_test.go:24 +0x5f fp=0xc0003ddea8 sp=0xc0003dde50 pc=0x13f863f
testing.tRunner(0xc000410820, 0x1794708)

2023-02-23 13:00 windows-amd64-race tools@4906a71e go@ac556f35 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd (log)

serve.go:434: debug server listening at http://localhost:49772
serve.go:434: debug server listening at http://localhost:49773
#### Start Gopls Test Logs for "TestRunGovulncheckStd/default"
[Trace - 13:09:27.252 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-37843534\\TestRunGovulncheckStd\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-37843534/TestRunGovulncheckStd/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test1551669222","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-37843534/TestRunGovulncheckStd/default/work","name":"work"}]}


[Trace - 13:09:27.254 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckStd (1.44s)
    --- FAIL: TestRunGovulncheckStd/default (1.43s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 7449469827911975946" is met, must have:
            received ShowMessage
            no diagnostics for file "go.mod"

            err:condition has final verdict Unmeetable

            state:
...

[Trace - 13:09:33.170 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2023/02/23 13:09:33 ()\n\tC:/workdir/go/src/runtime/mgc.go:1275 +0xf1 fp=0xc0003ddfe0 sp=0xc0003ddf50 pc=0x4610d1\nruntime.goexit()\n\tC:/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0003ddfe8 sp=0xc0003ddfe0 pc=0x4b5b61\ncreated by runtime.gcBgMarkStartWorkers\n\tC:/workdir/go/src/runtime/mgc.go:1199 +0x25\n\ngoroutine 87 [GC worker (idle)]:\nruntime.gopark(0x76f35ec1c0?, 0x0?, 0x0?, 0x0?, 0x0?)\n\tC:/workdir/go/src/runtime/proc.go:381 +0xd6 fp=0xc0003e3f50 sp=0xc0003e3f30 pc=0x482276\nruntime.gcBgMarkWorker()\n\tC:/workdir/go/src/runtime/mgc.go:1275 +0xf1 fp=0xc0003e3fe0 sp=0xc0003e3f50 pc=0x4610d1\nruntime.goexit()\n\tC:/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0003e3fe8 sp=0xc0003e3fe0 pc=0x4b5b61\ncreated by runtime.gcBgMarkStartWorkers\n\tC:/workdir/go/src/runtime/mgc.go:1199 +0x25\n\n\toperation=\"vulncheck\"\n"}


[Trace - 13:09:33.177 PM] Received notification '$/progress'.
Params: {"token":"4642189030961894313","value":{"kind":"end","message":"failed"}}


#### End Gopls Test Logs for "TestRunVulncheckWarning/default"

— watchflakes

gopherbot · 2023-02-25T09:38:39Z

Change https://go.dev/cl/471335 mentions this issue: syscall: fix invalid unsafe.Pointer conversion on Windows

gopherbot · 2023-02-27T20:53:42Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

2023-02-27 20:01 windows-amd64-race tools@b0fcf2a0 go@1362737f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd (log)

serve.go:434: debug server listening at http://localhost:49787
serve.go:434: debug server listening at http://localhost:49788
#### Start Gopls Test Logs for "TestRunGovulncheckStd/default"
[Trace - 20:31:56.442 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-952775969\\TestRunGovulncheckStd\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-952775969/TestRunGovulncheckStd/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test851508177","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-952775969/TestRunGovulncheckStd/default/work","name":"work"}]}


[Trace - 20:31:56.445 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckStd (2.07s)
    --- FAIL: TestRunGovulncheckStd/default (2.05s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 3859460889537685014" is met, must have:
            received ShowMessage
            no diagnostics for file "go.mod"

            err:condition has final verdict Unmeetable

            state:
...
            	Error: "2023/02/27 20:31:58 command error: failed to run ...

            #### diagnostics:

            #### outstanding work:
            	diagnosing opened files: 0.00
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1

— watchflakes

bcmills · 2023-02-27T21:01:02Z

@gopherbot, please backport to Go 1.19 and 1.20. These failures also occur on at least release-branch.go1.20.

gopherbot · 2023-02-27T21:01:29Z

Backport issue(s) opened: #58773 (for 1.19), #58774 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

gopherbot · 2023-02-27T21:09:27Z

Change https://go.dev/cl/471599 mentions this issue: [release-branch.go1.20] syscall: fix invalid unsafe.Pointer conversion on Windows

gopherbot · 2023-02-28T15:28:39Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

2023-02-28 15:06 windows-amd64-race tools@902ee93c go@aef8a8cd x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd (log)

serve.go:434: debug server listening at http://localhost:49774
serve.go:434: debug server listening at http://localhost:49775
#### Start Gopls Test Logs for "TestRunGovulncheckStd/default"
[Trace - 15:27:26.531 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-1830532786\\TestRunGovulncheckStd\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1830532786/TestRunGovulncheckStd/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test1509237402","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1830532786/TestRunGovulncheckStd/default/work","name":"work"}]}


[Trace - 15:27:26.533 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckStd (1.47s)
    --- FAIL: TestRunGovulncheckStd/default (1.46s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 7853334821515303790" is met, must have:
            received ShowMessage
            no diagnostics for file "go.mod"

            err:condition has final verdict Unmeetable

            state:
...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

bcmills · 2023-02-28T17:20:59Z

aef8a8cd is also release-branch.go1.20.

gopherbot · 2023-02-28T20:12:53Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

2023-02-28 19:36 windows-amd64-race tools@120642f1 go@aef8a8cd x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd (log)

serve.go:434: debug server listening at http://localhost:49777
serve.go:434: debug server listening at http://localhost:49778
#### Start Gopls Test Logs for "TestRunGovulncheckStd/default"
[Trace - 20:02:17.145 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-825553315\\TestRunGovulncheckStd\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-825553315/TestRunGovulncheckStd/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test958478339","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-825553315/TestRunGovulncheckStd/default/work","name":"work"}]}


[Trace - 20:02:17.148 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckStd (1.68s)
    --- FAIL: TestRunGovulncheckStd/default (1.66s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 6874326948282412" is met, must have:
            received ShowMessage
            no diagnostics for file "go.mod"

            err:condition has final verdict Unmeetable

            state:
...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1

— watchflakes

…n on Windows Updates #58714 Fixes #58774 Change-Id: Ifa5c059ed5e358ed98aee7e83b95dd1806b535f7 Reviewed-on: https://go-review.googlesource.com/c/go/+/471335 Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Bryan Mills <bcmills@google.com> (cherry picked from commit de8c999) Reviewed-on: https://go-review.googlesource.com/c/go/+/471599 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Bryan Mills <bcmills@google.com>

mknyszek · 2023-03-01T20:20:45Z

In triage: @bcmills Is this effectively done? Should this issue be closed?

bcmills · 2023-03-01T21:22:01Z

Yes, this is done; watchflakes erroneously reopened it again (see #57632).

…n on Windows Updates golang#58714 Fixes golang#58774 Change-Id: Ifa5c059ed5e358ed98aee7e83b95dd1806b535f7 Reviewed-on: https://go-review.googlesource.com/c/go/+/471335 Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Bryan Mills <bcmills@google.com> (cherry picked from commit de8c999) Reviewed-on: https://go-review.googlesource.com/c/go/+/471599 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Bryan Mills <bcmills@google.com>

gopherbot · 2023-03-08T18:18:40Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "windows" && log ~ `fatal error: checkptr: converted pointer straddles multiple allocations` && log ~ `syscall\.Environ`

2023-02-25 00:08 windows-amd64-race tools@f98fce20 go@1362737f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd (log)

serve.go:434: debug server listening at http://localhost:49785
serve.go:434: debug server listening at http://localhost:49786
#### Start Gopls Test Logs for "TestRunGovulncheckStd/default"
[Trace - 20:21:24.326 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-2353669230\\TestRunGovulncheckStd\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-2353669230/TestRunGovulncheckStd/default/proxy","GOSUMDB":"off","GOVULNDB":"file:///C:/Users/gopher/AppData/Local/Temp/1/vulndb-test2984818784","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true","_GOPLS_TEST_VULNCHECK_GOVERSION":"go1.18"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-2353669230/TestRunGovulncheckStd/default/work","name":"work"}]}


[Trace - 20:21:24.328 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckStd (1.49s)
    --- FAIL: TestRunGovulncheckStd/default (1.48s)
        env.go:322: waiting on:
            Unmeetable: once "completed work for token 2080803042408190548" is met, must have:
            received ShowMessage
            no diagnostics for file "go.mod"

            err:condition has final verdict Unmeetable

            state:
...

            #### diagnostics:
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

alexbrainman · 2023-03-08T21:46:10Z

x/tools/gopls/internal/regtest/misc.TestRunGovulncheckStd

Looks like x/tools/... uses old version of x/sys/windows package that contains this bug.

Reopening this issue so we remember to update x/tools to the later version.

Alex

bcmills · 2023-03-08T21:54:40Z

I don't think x/tools is actually using the affected x/sys/windows function. The most recent failure attached by watchflakes lists C:/workdir/go/src/syscall/env_windows.go:83, and go commit 1362737 was on release-branch.go1.20 prior to the backport to that branch (which was CL 471335).

gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 24, 2023

bcmills added this to Test Flakes Feb 24, 2023

bcmills added this to the Go1.21 milestone Feb 24, 2023

bcmills added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Feb 24, 2023

bcmills mentioned this issue Feb 24, 2023

runtime: corruption in tests #55167

Open

gopherbot closed this as completed in de8c999 Feb 27, 2023

github-project-automation bot moved this to Done in Test Flakes Feb 27, 2023

gopherbot reopened this Feb 27, 2023

This was referenced Feb 27, 2023

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.19 backport] #58773

Closed

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows [1.20 backport] #58774

Closed

bcmills closed this as completed Feb 27, 2023

gopherbot reopened this Feb 28, 2023

bcmills closed this as completed Feb 28, 2023

This was referenced Feb 28, 2023

x/tools/gopls/internal/regtest/misc: TestRunVulncheckWarning failures #58709

Closed

x/tools/gopls/internal/regtest/misc: TestRunVulncheckPackageDiagnostics failures #58705

Closed

gopherbot reopened this Feb 28, 2023

findleyr mentioned this issue Mar 1, 2023

x/tools/gopls/internal/regtest/misc: TestRunGovulncheckError2 failures #57032

Closed

findleyr mentioned this issue Mar 1, 2023

x/tools/gopls/internal/lsp: TestLSP failures #58702

Closed

mknyszek added this to Go Compiler / Runtime Mar 1, 2023

mknyszek assigned bcmills Mar 1, 2023

mknyszek moved this to Done in Go Compiler / Runtime Mar 1, 2023

bcmills closed this as completed Mar 1, 2023

alexbrainman reopened this Mar 8, 2023

github-project-automation bot moved this from Done to In Progress in Go Compiler / Runtime Mar 8, 2023

bcmills closed this as completed Mar 8, 2023

github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Mar 8, 2023

bcmills mentioned this issue Apr 7, 2023

x/build/cmd/watchflakes: adjust behavior for non-default branches #59483

Open

2 tasks

mknyszek removed this from Go Compiler / Runtime Apr 19, 2023

golang locked and limited conversation to collaborators Mar 7, 2024

gopherbot added the FrozenDueToAge label Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syscall: `Environ` uses an invalid `unsafe.Pointer` conversion on Windows #58714

syscall: `Environ` uses an invalid `unsafe.Pointer` conversion on Windows #58714

bcmills commented Feb 24, 2023 •

edited

Loading

bcmills commented Feb 24, 2023

bcmills commented Feb 24, 2023

gopherbot commented Feb 24, 2023

gopherbot commented Feb 25, 2023

gopherbot commented Feb 27, 2023

bcmills commented Feb 27, 2023

gopherbot commented Feb 27, 2023

gopherbot commented Feb 27, 2023

gopherbot commented Feb 28, 2023

bcmills commented Feb 28, 2023

gopherbot commented Feb 28, 2023

mknyszek commented Mar 1, 2023

bcmills commented Mar 1, 2023

gopherbot commented Mar 8, 2023

alexbrainman commented Mar 8, 2023

bcmills commented Mar 8, 2023 •

edited

Loading

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows #58714

syscall: Environ uses an invalid unsafe.Pointer conversion on Windows #58714

Comments

bcmills commented Feb 24, 2023 • edited Loading

bcmills commented Feb 24, 2023

bcmills commented Feb 24, 2023

gopherbot commented Feb 24, 2023

gopherbot commented Feb 25, 2023

gopherbot commented Feb 27, 2023

bcmills commented Feb 27, 2023

gopherbot commented Feb 27, 2023

gopherbot commented Feb 27, 2023

gopherbot commented Feb 28, 2023

bcmills commented Feb 28, 2023

gopherbot commented Feb 28, 2023

mknyszek commented Mar 1, 2023

bcmills commented Mar 1, 2023

gopherbot commented Mar 8, 2023

alexbrainman commented Mar 8, 2023

bcmills commented Mar 8, 2023 • edited Loading

syscall: `Environ` uses an invalid `unsafe.Pointer` conversion on Windows #58714

syscall: `Environ` uses an invalid `unsafe.Pointer` conversion on Windows #58714

bcmills commented Feb 24, 2023 •

edited

Loading

bcmills commented Mar 8, 2023 •

edited

Loading