Skip to content

x/tools/gopls/internal/regtest/misc: TestRunGovulncheckError2 failures #57032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Dec 1, 2022 · 26 comments
Closed

x/tools/gopls/internal/regtest/misc: TestRunGovulncheckError2 failures #57032

gopherbot opened this issue Dec 1, 2022 · 26 comments
Assignees
@hyangah
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"

Issue created automatically to collect these failures.

Example (log):

serve.go:434: debug server listening at http://localhost:65429
serve.go:434: debug server listening at http://localhost:65428
2022/12/01 19:58:33 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3230: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 19:59:18.329 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 19:59:18.329 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.26s)
    --- FAIL: TestRunGovulncheckError2/default (0.26s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 6224113210504995324" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 1, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 19:51 netbsd-amd64-9_3 tools@e79e423f go@9f443332 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:65429
serve.go:434: debug server listening at http://localhost:65428
2022/12/01 19:58:33 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3230: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 19:59:18.329 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-636137007/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 19:59:18.329 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.26s)
    --- FAIL: TestRunGovulncheckError2/default (0.26s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 6224113210504995324" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 1, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 1, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 19:51 linux-386 tools@e79e423f go@8fd2875c x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:46459
serve.go:434: debug server listening at http://localhost:38237
2022/12/01 20:01:32 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 20:02:04.667 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-3612820566/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-3612820566/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-3612820566/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 20:02:04.668 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.12s)
    --- FAIL: TestRunGovulncheckError2/default (0.12s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 2755337900539534759" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 19:51 openbsd-386-70 tools@e79e423f go@9f443332 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:47589
serve.go:434: debug server listening at http://localhost:18115
2022/12/01 12:22:50 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3230: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 12:29:18.473 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-80830408/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-80830408/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-80830408/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 12:29:18.475 PM] Received response 'initialize - (1)' in 1ms.
...
--- FAIL: TestRunGovulncheckError2 (1.08s)
    --- FAIL: TestRunGovulncheckError2/default (1.08s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 3416836964790359329" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:10 linux-386-bullseye tools@0379b73a go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:38237
serve.go:434: debug server listening at http://localhost:39573
2022/12/01 21:19:30 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:19:57.585 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-588388849/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-588388849/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-588388849/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:19:57.585 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.11s)
    --- FAIL: TestRunGovulncheckError2/default (0.11s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4307216415901086287" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-01 21:10 linux-amd64-nocgo tools@0379b73a go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:37331
serve.go:434: debug server listening at http://localhost:45001
2022/12/01 21:18:41 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:19:08.348 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-4007150483/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-4007150483/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-4007150483/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:19:08.349 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.11s)
    --- FAIL: TestRunGovulncheckError2/default (0.11s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 900776273228002089" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 21:10 linux-arm64-aws tools@0379b73a go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:38599
serve.go:434: debug server listening at http://localhost:44813
2022/12/01 21:19:19 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:19:40.858 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-3516879914/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-3516879914/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-3516879914/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:19:40.858 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.13s)
    --- FAIL: TestRunGovulncheckError2/default (0.13s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4670740930031969081" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:10 netbsd-amd64-9_3 tools@0379b73a go@9f443332 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:65437
serve.go:434: debug server listening at http://localhost:65436
2022/12/01 21:22:34 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3230: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:23:18.099 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-4235417099/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-4235417099/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-4235417099/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:23:18.099 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.15s)
    --- FAIL: TestRunGovulncheckError2/default (0.15s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 1466410764845344422" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:30 linux-amd64-longtest tools@d54e12bf go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:40611
serve.go:434: debug server listening at http://localhost:34205
2022/12/01 21:35:05 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/forwarded"
[Trace - 21:36:27.130 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-206368833/TestRunGovulncheckError2/forwarded/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-206368833/TestRunGovulncheckError2/forwarded/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-206368833/TestRunGovulncheckError2/forwarded/work","name":"work"}]}


[Trace - 21:36:27.130 PM] Received notification 'window/logMessage'.
...
--- FAIL: TestRunGovulncheckError2 (0.34s)
    --- FAIL: TestRunGovulncheckError2/forwarded (0.12s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 802595657908186352" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:30 netbsd-amd64-9_3 tools@d54e12bf go@e727f419 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:65450
serve.go:434: debug server listening at http://localhost:65449
2022/12/01 21:50:16 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3197: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:51:25.920 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-931755290/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-931755290/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-931755290/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:51:25.920 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.20s)
    --- FAIL: TestRunGovulncheckError2/default (0.19s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 3565596104265814390" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Dec 1, 2022

(attn @hyangah)

@bcmills bcmills added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Dec 1, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/454638 mentions this issue: gopls/internal/regtest/misc: skip TestRunGovulncheckError2

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:30 windows-arm64-10 tools@d54e12bf go@0e8b6056 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:50090
serve.go:434: debug server listening at http://localhost:50091
2022/12/01 21:05:18 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
invoke.go:285: error killing the Go command: TerminateProcess: Access is denied.
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:08:27.693 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\gopls-regtest-601178329\\TestRunGovulncheckError2\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/gopls-regtest-601178329/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/gopls-regtest-601178329/TestRunGovulncheckError2/default/work","name":"work"}]}


...
--- FAIL: TestRunGovulncheckError2 (0.48s)
    --- FAIL: TestRunGovulncheckError2/default (0.48s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 1367957263893944069" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1

— watchflakes

gopherbot pushed a commit to golang/tools that referenced this issue Dec 1, 2022
@hyangah @gopherbot
gopls/internal/regtest/misc: skip TestRunGovulncheckError2
47a8246 
Skipping while investigating a better option to test error
handling behavior.

Updates golang/go#57032

Change-Id: Ifa7924a013ed092ac6acfc85f06aff48b2035721
Reviewed-on: https://go-review.googlesource.com/c/tools/+/454638
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:30 linux-amd64-race tools@d54e12bf go@6a70292d x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:35797
serve.go:434: debug server listening at http://localhost:44199
2022/12/01 22:18:04 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 22:18:43.087 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-1688984729/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-1688984729/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-1688984729/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 22:18:43.089 PM] Received response 'initialize - (1)' in 1ms.
...
--- FAIL: TestRunGovulncheckError2 (0.20s)
    --- FAIL: TestRunGovulncheckError2/default (0.20s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 3279296533168393667" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/454775 mentions this issue: gopls/internal/lsp/regtest: fix TestRunGovulncheckError2

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 19:51 linux-amd64-alpine tools@e79e423f go@86963b45 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:39841
serve.go:434: debug server listening at http://localhost:45549
2022/12/01 21:09:21 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:09:45.349 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-695626113/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-695626113/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-695626113/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:09:45.349 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.11s)
    --- FAIL: TestRunGovulncheckError2/default (0.11s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 3768572047054606116" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 19:51 linux-amd64-alpine tools@e79e423f go@8ed74ee3 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:34769
serve.go:434: debug server listening at http://localhost:46777
2022/12/01 21:04:13 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:04:40.872 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-4235696983/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-4235696983/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-4235696983/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:04:40.872 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.12s)
    --- FAIL: TestRunGovulncheckError2/default (0.12s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 7548313753360702115" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 19:51 linux-amd64-longtest tools@e79e423f go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:37769
serve.go:434: debug server listening at http://localhost:33315
2022/12/01 21:13:52 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/forwarded"
[Trace - 21:15:10.800 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-148028024/TestRunGovulncheckError2/forwarded/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-148028024/TestRunGovulncheckError2/forwarded/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-148028024/TestRunGovulncheckError2/forwarded/work","name":"work"}]}


[Trace - 21:15:10.800 PM] Received notification 'window/logMessage'.
...
--- FAIL: TestRunGovulncheckError2 (0.33s)
    --- FAIL: TestRunGovulncheckError2/forwarded (0.12s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 1803263531578416089" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-01 19:51 linux-amd64-longtest-race tools@e79e423f go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:33013
serve.go:434: debug server listening at http://localhost:36639
2022/12/01 21:22:58 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:26:31.131 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-927398057/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-927398057/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-927398057/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:26:31.132 PM] Received response 'initialize - (1)' in 1ms.
...
--- FAIL: TestRunGovulncheckError2 (0.65s)
    --- FAIL: TestRunGovulncheckError2/default (0.20s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 8522315886063158998" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-01 19:51 linux-amd64-longtest-race tools@e79e423f go@8ed74ee3 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:41223
serve.go:434: debug server listening at http://localhost:35293
2022/12/01 21:11:49 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/forwarded"
[Trace - 21:15:46.750 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-1908580001/TestRunGovulncheckError2/forwarded/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-1908580001/TestRunGovulncheckError2/forwarded/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-1908580001/TestRunGovulncheckError2/forwarded/work","name":"work"}]}


[Trace - 21:15:46.750 PM] Received notification 'window/logMessage'.
...
--- FAIL: TestRunGovulncheckError2 (0.76s)
    --- FAIL: TestRunGovulncheckError2/forwarded (0.28s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 7260458732192460207" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 19:51 linux-ppc64le-buildlet tools@e79e423f go@8ed74ee3 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:45939
serve.go:434: debug server listening at http://localhost:40117
2022/12/01 21:07:03 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:08:22.736 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-3309481020/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-3309481020/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-3309481020/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:08:22.736 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.83s)
    --- FAIL: TestRunGovulncheckError2/default (0.83s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 1612310636972798243" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 21:10 linux-amd64-clang tools@0379b73a go@e727f419 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:43753
serve.go:434: debug server listening at http://localhost:35009
2022/12/01 21:17:14 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3197: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:17:38.615 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-1015890841/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-1015890841/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-1015890841/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:17:38.615 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.13s)
    --- FAIL: TestRunGovulncheckError2/default (0.13s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4738316528773773538" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 21:10 linux-ppc64le-buildlet tools@0379b73a go@e727f419 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:37789
serve.go:434: debug server listening at http://localhost:44781
2022/12/01 22:07:24 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3197: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 22:08:30.904 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-2180266502/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-2180266502/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-2180266502/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 22:08:30.904 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.40s)
    --- FAIL: TestRunGovulncheckError2/default (0.40s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4978344379971585616" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-01 21:10 netbsd-386-9_3 tools@0379b73a go@e727f419 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:65442
serve.go:434: debug server listening at http://localhost:65441
2022/12/01 21:22:56 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3197: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 21:23:53.934 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1407229390/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1407229390/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1407229390/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 21:23:53.934 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.15s)
    --- FAIL: TestRunGovulncheckError2/default (0.15s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 3777619644437330793" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
2022-12-01 21:30 freebsd-arm64-dmgk tools@d54e12bf go@9f443332 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:27752
serve.go:434: debug server listening at http://localhost:25168
2022/12/02 01:44:47 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3230: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 01:46:09.822 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-2684052786/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-2684052786/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-2684052786/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 01:46:09.823 AM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.53s)
    --- FAIL: TestRunGovulncheckError2/default (0.53s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 2747474448652852629" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
2022-12-01 21:30 linux-amd64-longtest-race tools@d54e12bf go@0e8b6056 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:45485
serve.go:434: debug server listening at http://localhost:39481
2022/12/01 21:45:23 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/experimental"
[Trace - 21:48:56.370 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-183655804/TestRunGovulncheckError2/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-183655804/TestRunGovulncheckError2/experimental/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-183655804/TestRunGovulncheckError2/experimental/work","name":"work"}]}


[Trace - 21:48:56.372 PM] Received response 'initialize - (1)' in 1ms.
...
--- FAIL: TestRunGovulncheckError2 (0.65s)
    --- FAIL: TestRunGovulncheckError2/experimental (0.21s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4218055474879305077" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1

— watchflakes

@bcmills bcmills removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Dec 7, 2022
@gopherbot gopherbot moved this to Done in Test Flakes Dec 8, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/456636 mentions this issue: gopls/internal/lsp/regtest: fix TestRunGovulncheckError2

gopherbot pushed a commit to golang/tools that referenced this issue Dec 9, 2022
@hyangah
[gopls-release-branch.0.11] gopls/internal/lsp/regtest: fix TestRunGo…
486713e 
…vulncheckError2

Changes CompletedProgress to take an optional WorkState
which is filled when the expectation is met (i.e. completed progress)

Fixes golang/go#57032

Change-Id: Ie876d4d5a739e31b758b5affa2e9d6e4fb772dd5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/454775
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456636
@gopherbot gopherbot reopened this Jan 4, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:30 freebsd-arm64-dmgk tools@d54e12bf go@6a70292d x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:37353
serve.go:434: debug server listening at http://localhost:14785
2022/12/02 00:06:14 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 00:07:34.947 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1345195496/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1345195496/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1345195496/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 00:07:34.948 AM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.44s)
    --- FAIL: TestRunGovulncheckError2/default (0.44s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4275826215964144511" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
2022-12-01 21:30 linux-amd64-longtest tools@d54e12bf go@6a70292d x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:39747
serve.go:434: debug server listening at http://localhost:35067
2022/12/01 22:12:37 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/experimental"
[Trace - 22:13:58.800 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-2645563362/TestRunGovulncheckError2/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-2645563362/TestRunGovulncheckError2/experimental/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-2645563362/TestRunGovulncheckError2/experimental/work","name":"work"}]}


[Trace - 22:13:58.801 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.36s)
    --- FAIL: TestRunGovulncheckError2/experimental (0.11s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 2148193347687608549" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2022-12-01 21:30 linux-amd64-longtest-race tools@d54e12bf go@6a70292d x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:41639
serve.go:434: debug server listening at http://localhost:37559
2022/12/01 22:18:24 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/forwarded"
[Trace - 22:21:53.268 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-595887004/TestRunGovulncheckError2/forwarded/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-595887004/TestRunGovulncheckError2/forwarded/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-595887004/TestRunGovulncheckError2/forwarded/work","name":"work"}]}


[Trace - 22:21:53.268 PM] Received notification 'window/logMessage'.
...
--- FAIL: TestRunGovulncheckError2 (0.62s)
    --- FAIL: TestRunGovulncheckError2/forwarded (0.23s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 6259395767376370704" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1

— watchflakes

@bcmills bcmills closed this as completed Jan 5, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2022-12-01 21:10 linux-amd64-longtest-race tools@0379b73a go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:33475
serve.go:434: debug server listening at http://localhost:33591
2022/12/01 21:33:25 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/forwarded"
[Trace - 21:36:23.448 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-3705828250/TestRunGovulncheckError2/forwarded/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-3705828250/TestRunGovulncheckError2/forwarded/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-3705828250/TestRunGovulncheckError2/forwarded/work","name":"work"}]}


[Trace - 21:36:23.449 PM] Received notification 'window/logMessage'.
...
--- FAIL: TestRunGovulncheckError2 (0.51s)
    --- FAIL: TestRunGovulncheckError2/forwarded (0.19s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 4880887867119746047" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-01 21:10 linux-ppc64le-buildlet tools@0379b73a go@c71d3a0f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:36731
serve.go:434: debug server listening at http://localhost:40365
2022/12/01 22:02:45 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 22:04:07.541 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-3831400315/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-3831400315/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-3831400315/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 22:04:07.541 PM] Received response 'initialize - (1)' in 0ms.
...
--- FAIL: TestRunGovulncheckError2 (0.92s)
    --- FAIL: TestRunGovulncheckError2/default (0.92s)
        vuln_test.go:83: waiting on:
            Unmeetable: once "completed work for token 8385829670606806843" is met, must have:
            log message matching "failed to load packages due to errors" expected 1 times

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	foo.go (version 0):
            		(3, 0) [syntax]: expected ';', found 'EOF'
            	go.mod (version 1):

            #### outstanding work:
            #### completed work:
            	govulncheck: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1

— watchflakes

@gopherbot gopherbot reopened this Feb 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2023-02-22 15:03 windows-amd64-race tools@e85b5336 go@7b398b1f x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:49778
serve.go:434: debug server listening at http://localhost:49779
invoke.go:285: error killing the Go command: invalid argument
invoke.go:285: error killing the Go command: invalid argument
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 15:26:29.633 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-3355993819\\TestRunGovulncheckError2\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-3355993819/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-3355993819/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 15:26:29.636 PM] Received response 'initialize - (1)' in 2ms.
...
--- FAIL: TestRunGovulncheckError2 (0.53s)
    --- FAIL: TestRunGovulncheckError2/default (0.53s)
        vuln_test.go:90: work status = {Msg::1275 +0xf1 fp=0xc0002dffe0 sp=0xc0002dff50 pc=0x4610d1
            runtime.goexit()
            	C:/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0002dffe8 sp=0xc0002dffe0 pc=0x4b5b61
            created by runtime.gcBgMarkStartWorkers
            	C:/workdir/go/src/runtime/mgc.go:1199 +0x25


[Trace - 15:26:39.426 PM] Received response 'initialize - (1)' in 1ms.
...

[Trace - 15:26:40.073 PM] Received notification '$/progress'.
Params: {"token":"6165442798648293397","value":{"kind":"end","message":"failed"}}


[Trace - 15:26:40.074 PM] Received notification 'window/showMessage'.
Params: {"type":1,"message":"failed to run govulncheck: exit status 2"}


#### End Gopls Test Logs for "TestRunVulncheckPackageDiagnostics/imports/default"

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2023-02-25 00:08 windows-amd64-race tools@f98fce20 go@ac556f35 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:49781
serve.go:434: debug server listening at http://localhost:49782
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 00:32:31.674 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-612945839\\TestRunGovulncheckError2\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-612945839/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-612945839/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 00:32:31.677 AM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...


#### End Gopls Test Logs for "TestRunGovulncheckError2/default"
--- FAIL: TestRunGovulncheckError2 (0.66s)
    --- FAIL: TestRunGovulncheckError2/default (0.66s)
        vuln_test.go:90: work status = {Msg:0xf1 fp=0xc00041bfe0 sp=0xc00041bf50 pc=0x4610d1
            runtime.goexit()
            	C:/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc00041bfe8 sp=0xc00041bfe0 pc=0x4b5b61
            created by runtime.gcBgMarkStartWorkers
            	C:/workdir/go/src/runtime/mgc.go:1199 +0x25

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2023-02-27 20:01 windows-amd64-race tools@b0fcf2a0 go@ef793801 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:434: debug server listening at http://localhost:49775
serve.go:434: debug server listening at http://localhost:49776
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 02:14:09.135 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-426585644\\TestRunGovulncheckError2\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-426585644/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-426585644/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 02:14:09.137 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.20.1\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}

...
--- FAIL: TestRunGovulncheckError2 (0.55s)
    --- FAIL: TestRunGovulncheckError2/default (0.55s)
        vuln_test.go:90: work status = {Msg::1275 +0xf1 fp=0xc0002dbfe0 sp=0xc0002dbf50 pc=0x4610d1
            runtime.goexit()
            	C:/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc0002dbfe8 sp=0xc0002dbfe0 pc=0x4b5b61
            created by runtime.gcBgMarkStartWorkers
            	C:/workdir/go/src/runtime/mgc.go:1199 +0x25


[Trace - 02:14:21.986 AM] Received response 'initialize - (1)' in 2ms.
...

[Trace - 02:14:22.496 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/02/28 02:14:22 command error: failed to run govulncheck: exit status 2\n"}


[Trace - 02:14:22.497 AM] Received notification 'window/showMessage'.
Params: {"type":1,"message":"failed to run govulncheck: exit status 2"}


#### End Gopls Test Logs for "TestRunVulncheckWarning/default"

— watchflakes

@findleyr
Copy link
Member

findleyr commented Mar 1, 2023

Reoccurrence is #58714

@findleyr findleyr closed this as completed Mar 1, 2023
@gopherbot gopherbot reopened this Sep 14, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestRunGovulncheckError2"
2023-09-13 21:17 linux-s390x-ibm tools@715a4527 go@de4ead81 x/tools/gopls/internal/regtest/misc.TestRunGovulncheckError2 (log) 
serve.go:443: debug server listening at http://localhost:41353
serve.go:443: debug server listening at http://localhost:41141
#### Start Gopls Test Logs for "TestRunGovulncheckError2/default"
[Trace - 06:12:45.115 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"codelenses":{"run_govulncheck":true},"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/proxy","GOSUMDB":"off","_GOPLS_TEST_BINARY_RUN_AS_GOPLS":"true"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/work","name":"work"}]}


[Trace - 06:12:45.115 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":[],"tokenModifiers":[]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel de4ead8102c3ba5dc9475ed3e117b2c50220b4df\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}

...


[Trace - 06:12:45.821 AM] Received notification '$/progress'.
Params: {"token":"7370338383097207849","value":{"kind":"end","message":"failed"}}


#### End Gopls Test Logs for "TestRunGovulncheckError2/default"
--- FAIL: TestRunGovulncheckError2 (0.72s)
    --- FAIL: TestRunGovulncheckError2/default (0.72s)
        vuln_test.go:90: work status = {Msg:DB: https://vuln.go.dev (DB updated: 2023-09-13 19:45:03 +0000 UTC) EndMsg:failed}, want {EndMessage: "failed", Message: "There are errors with the provided package patterns:"}

— watchflakes

@hyangah
Copy link
Contributor

hyangah commented Sep 15, 2023 


[Trace - 06:12:45.229 AM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: {"Token":"7370338383097207849"}


[Trace - 06:12:45.330 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/work/go.mod","version":1,"diagnostics":[]}


[Trace - 06:12:45.330 AM] Received notification '$/progress'.
Params: {"token":"855739803297378775","value":{"kind":"end","message":"Done."}}


[Trace - 06:12:45.817 AM] Received notification '$/progress'.
Params: {"token":"7370338383097207849","value":{"kind":"report","cancellable":true,"message":"govulncheck: loading packages: \nThere are errors with the provided package patterns:\n\n/data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/work/foo.go:3:38: expected ';', found 'EOF'\n/data/golang/workdir/tmp/gopls-regtest-3719265748/TestRunGovulncheckError2/default/work/foo.go:3:38: expected '}', found 'EOF'\n\nFor details on package patterns, see https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns.\n"}}


[Trace - 06:12:45.818 AM] Received notification '$/progress'.
Params: {"token":"7370338383097207849","value":{"kind":"report","cancellable":true,"message":"Go: devel de4ead8102c3ba5dc9475ed3e117b2c50220b4df"}}


[Trace - 06:12:45.818 AM] Received notification '$/progress'.
Params: {"token":"7370338383097207849","value":{"kind":"report","cancellable":true,"message":"DB: https://vuln.go.dev (DB updated: 2023-09-13 19:45:03 +0000 UTC)"}}


[Trace - 06:12:45.821 AM] Received notification '$/progress'.
Params: {"token":"7370338383097207849","value":{"kind":"end","message":"failed"}}

Looks like this was caused by two goroutines racing

  • goroutine 1: forwarding gopls vulncheck -json process's STDERR to progress report.

  • goroutine 2: parsing gopls vulncheck -json process's STDOUT stream and reporting the db info to progress report.

And the test was checking whether last progress report contains explanation on the failure. gopls vulncheck (and govulncheck) reports the error in STDERR, so it should be processed from goroutine 1 (STDERR). Usually, the preamble messages sent by goroutine2 arrive before error reports, and that is desirable for users. But in this failure case, goroutine2 lost in the race.

Merging two streams (STDOUT/STDERR) into one progress report output stream is tricky. Especially, the info sent to STDOUT needs to be post-processed so it will add more delays.

I think it would've been much simpler for govulncheck API users if the preamble and progress reports were out of the JSON streams -json produces. cc @ianthehat @zpavlinovic

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/528361 mentions this issue: gopls/internal/vulncheck/scan: buffer govulncheck STDERR output

gopherbot pushed a commit to golang/tools that referenced this issue Sep 19, 2023
@hyangah
gopls/internal/vulncheck/scan: buffer govulncheck STDERR output
6128895 
Govulncheck scan API rarely outputs anything through STDERR.
Messages shown in govulncheck scan API's stderr indicate real problems
and it's better to show at the end when the scan fails.

Buffer STDERR messages and sent them only when the command has failed
and the goroutine that post-processes STDOUT stream has terminated.
That will eliminate race between progress reports produced from STDERR
and from STDOUT.

Updates golang/go#57032

Change-Id: Ibd73668b11c07b83ea3aee55a43d6b8072c80870
Reviewed-on: https://go-review.googlesource.com/c/tools/+/528361
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.14.0 Sep 20, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 9, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023
@findleyr
Copy link
Member

findleyr commented Jan 6, 2024

@hyangah can this be closed?

@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Jan 6, 2024
@zpavlinovic
Copy link
Contributor

I think it would've been much simpler for govulncheck API users if the preamble and progress reports were out of the JSON streams -json produces. cc @ianthehat @zpavlinovic

We could skip emitting Config and Progress messages from the -json output, but that seems somewhat arbitrary. Some (CI) integration points might also want that part of json. The Config is especially useful for debugging.

I am curious, in what sense would it be easier to use the API if the Config and Progress are not emitted?

@findleyr
Copy link
Member

We think this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.16.0
Development

No branches or pull requests
5 participants
@zpavlinovic @hyangah @bcmills @gopherbot @findleyr