Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestWindowsStackMemory flakes on windows-386-2016 [1.19 backport] #61054

Closed
gopherbot opened this issue Jun 28, 2023 · 2 comments
Closed

runtime: TestWindowsStackMemory flakes on windows-386-2016 [1.19 backport] #61054

gopherbot opened this issue Jun 28, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.11

Comments

@gopherbot
Copy link
Contributor

@mknyszek requested issue #58570 to be considered for backport to the next 1.19 minor release.

@gopherbot Please open backport issues for Go 1.19 and Go 1.20.

This is a test-only fix that is very small and very safe.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 28, 2023
@gopherbot gopherbot mentioned this issue Jun 28, 2023
Open
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 28, 2023
@gopherbot gopherbot added this to the Go1.19.11 milestone Jun 28, 2023
@mknyszek mknyszek added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 28, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/506976 mentions this issue: [release-branch.go1.19] runtime: allow for 5 more threads in TestWindowsStackMemory*

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 28, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 16b1985 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jun 28, 2023
@alexbrainman @gopherbot
[release-branch.go1.19] runtime: allow for 5 more threads in TestWind…
16b1985 
…owsStackMemory*

Original version of TestWindowsStackMemory did not consider sysmon and
other threads running during the test. Allow for 5 extra threads in this
test - this should cover any new threads in the future.

For #58570
Fixes #61054

Change-Id: I215790f9b94ff40a32ddd7aa54af715d1dc391c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/473415
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit f6cbc1d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/506975
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 08a58dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/506976
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot