Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/env: host-linux-amd64-js-wasm-node18 (Container Image: js-wasm-node18:latest) #61104

Closed
Tracked by #60468
joedian opened this issue Jun 30, 2023 · 10 comments
Closed
Tracked by #60468

x/build/env: host-linux-amd64-js-wasm-node18 (Container Image: js-wasm-node18:latest) #61104

joedian opened this issue Jun 30, 2023 · 10 comments
Assignees
@dmitshur
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Milestone
Unreleased

Comments

@joedian
Copy link

joedian commented Jun 30, 2023

No description provided.

@joedian joedian mentioned this issue Jun 30, 2023
Open
35 tasks
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder labels Jul 5, 2023
@cagedmantis cagedmantis changed the title host-linux-amd64-js-wasm-node18 (Container Image: js-wasm-node18:latest) x/build/env: host-linux-amd64-js-wasm-node18 (Container Image: js-wasm-node18:latest) Jul 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 5, 2023
@bcmills bcmills added the arch-wasm WebAssembly issues label Jul 24, 2023
@dmitshur dmitshur self-assigned this Sep 19, 2023
@dmitshur dmitshur moved this to In Progress in Go Release Sep 19, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/530336 mentions this issue: main.star: start adding a js-wasm builder

@dmitshur dmitshur moved this to In Progress in Go Release Sep 22, 2023
gopherbot pushed a commit to golang/build that referenced this issue Oct 6, 2023
@dmitshur @gopherbot
main.star: start adding a js-wasm builder
8d00428 
Start by adding it as a post-submit builder, only in the main Go repo,
and only at tip. Mostly so it's easier to see the generated code and
iterate. Once it works, it'll be turned up in the remaining places.

It turns out there's more complexity here because this is the first
case where the host OS differs from the target port, and we wish to
run the golangbuild binary on the host OS. For now, the target port
is being communicated by explicitly setting GOOS and GOARCH env vars.

For golang/go#61104.

Change-Id: I25aa946aeb16ef43b44322c25e133d19e68e6555
Reviewed-on: https://go-review.googlesource.com/c/build/+/530336
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533263 mentions this issue: main.star: enable js-wasm builder presubmit coverage

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533262 mentions this issue: main.star: enable js-wasm builder for remaining x repos

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533260 mentions this issue: main.star: enable js-wasm builder on go repo's release branches

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533261 mentions this issue: main.star: enable js-wasm builder on two x repos

gopherbot pushed a commit to golang/build that referenced this issue Oct 6, 2023
@dmitshur @gopherbot
main.star: enable js-wasm builder on go repo's release branches
15e0490 
Taking small steps so it's easier to look over the generated files.

For golang/go#61104.

Change-Id: Ib11c8c30213d1de66575089b252127903a276737
Reviewed-on: https://go-review.googlesource.com/c/build/+/533260
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533264 mentions this issue: main.star: downgrade to Node 13 on release-branch.go1.20

gopherbot pushed a commit to golang/build that referenced this issue Oct 6, 2023
@dmitshur @gopherbot
main.star: downgrade to Node 13 on release-branch.go1.20
0527e15 
I thought it was Node 14 because of go.dev/cl/338730,
but it turns out the actual image still has Node 13.
To minimize new development work on release branches,
we're not going to do anything about that now.

For golang/go#61104.

Change-Id: I86d8f4ae4c1a5e0df6921326575141fa5338fc9f
Reviewed-on: https://go-review.googlesource.com/c/build/+/533264
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Oct 6, 2023
@dmitshur @gopherbot
main.star: enable js-wasm builder on two x repos
3f6b8ba 
One more gradual step. It exists in both x/arch and x/mobile now,
but only enabled in the former, as expected.

For golang/go#61104.

Change-Id: I5d2562bd7be8235797ba812f41f18f0ea4ba871a
Reviewed-on: https://go-review.googlesource.com/c/build/+/533261
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Oct 6, 2023
@dmitshur @gopherbot
main.star: enable js-wasm builder for remaining x repos
1344c35 
For golang/go#61104.

Change-Id: I9f80d6b2325896e154e8775a0c2fa502eff17eac
Reviewed-on: https://go-review.googlesource.com/c/build/+/533262
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533158 mentions this issue: cmd/gonew: skip Test if exec is unsupported

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533695 mentions this issue: all: add test skips for GOARCH=wasm

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/533696 mentions this issue: cmd/viewcore: don't try to build for GOARCH=wasm

gopherbot pushed a commit to golang/tools that referenced this issue Oct 9, 2023
@dmitshur @gopherbot
cmd/gonew: skip Test if exec is unsupported
0b06fd8 
The test can't run on platforms where exec is not implemented.
Make similar skip messages a bit more detailed and consistent.

For golang/go#61104.

Change-Id: I40cecd428cf0a7b6195aee146df6ed92deea0950
Cq-Include-Trybots: luci.golang.try:x_tools-gotip-js-wasm
Reviewed-on: https://go-review.googlesource.com/c/tools/+/533158
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/benchmarks that referenced this issue Oct 9, 2023
@dmitshur @gopherbot
all: add test skips for GOARCH=wasm
f835929 
These changes are enough to get 'GOOS=js GOARCH=wasm go test ./...'
to pass.

For golang/go#61104.

Change-Id: I78a2978a83a1026adeecc81b31bf7c2aa2db2155
Cq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-js-wasm
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/533695
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/debug that referenced this issue Oct 9, 2023
@dmitshur @gopherbot
cmd/viewcore: don't try to build for GOARCH=wasm
17d98cb 
It doesn't build for GOOS=js GOARCH=wasm the same reason it doesn't
build for aix and plan9: the readline dependency doesn't support it.

For golang/go#61104.

Change-Id: Ic7f45fda06c2b01555048e2e167ae0e188b2b492
Cq-Include-Trybots: luci.golang.try:x_debug-gotip-js-wasm
Reviewed-on: https://go-review.googlesource.com/c/debug/+/533696
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Oct 26, 2023
@dmitshur @gopherbot
main.star: enable js-wasm builder presubmit coverage
ad696da 
This is the last step after turning it on in postsubmit everywhere.

Inherit the previous build policy of enabling presubmit for js, wasip1
builders only in the main Go repo. Leave their postsubmit policy alone
for now. If it causes trouble, we can stop testing non-latest branches
of golang.org/x repos as configured in x/build/dashboard today.

Fixes golang/go#61104.

Change-Id: I374414fbb43d47c2d354b0d8f42d4a58baf4bc7c
Reviewed-on: https://go-review.googlesource.com/c/build/+/533263
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@dmitshur
Copy link
Contributor

This builder is turned up in LUCI, both in pre- and post-submit.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Oct 26, 2023
@dmitshur dmitshur mentioned this issue Nov 10, 2023
Closed
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this issue Apr 22, 2024
@dmitshur
all: add test skips for GOARCH=wasm
b4b0391 
These changes are enough to get 'GOOS=js GOARCH=wasm go test ./...'
to pass.

For golang/go#61104.

Change-Id: I78a2978a83a1026adeecc81b31bf7c2aa2db2155
Cq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-js-wasm
@golang golang locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitshur dmitshur

Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @dmitshur @bcmills @gopherbot @joedian